Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.3]Get rid of Rachet to fix failing build #649

Merged

Conversation

naveentatikonda
Copy link
Member

@naveentatikonda naveentatikonda commented Dec 5, 2022

Description

Backported from PR : #648
Cherry-picked from 4488fbd

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda naveentatikonda requested a review from a team December 5, 2022 19:43
@naveentatikonda naveentatikonda added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Dec 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #649 (4488fbd) into 1.3 (c66db06) will decrease coverage by 0.38%.
The diff coverage is 81.41%.

❗ Current head 4488fbd differs from pull request most recent head 1ddc1ee. Consider uploading reports for the commit 1ddc1ee to get more accurate results

@@             Coverage Diff              @@
##                1.3     #649      +/-   ##
============================================
- Coverage     84.27%   83.88%   -0.39%     
+ Complexity      901      900       -1     
============================================
  Files           127      127              
  Lines          3867     3879      +12     
  Branches        358      359       +1     
============================================
- Hits           3259     3254       -5     
- Misses          451      464      +13     
- Partials        157      161       +4     
Impacted Files Coverage Δ
.../main/java/org/opensearch/knn/index/KNNScorer.java 69.23% <0.00%> (ø)
.../opensearch/knn/index/KNNVectorIndexFieldData.java 100.00% <ø> (ø)
...opensearch/knn/index/KNNVectorScriptDocValues.java 90.47% <ø> (ø)
...opensearch/knn/index/codec/BinaryDocValuesSub.java 71.42% <ø> (ø)
...nsearch/knn/index/codec/KNN80Codec/KNN80Codec.java 31.57% <0.00%> (ø)
...rch/knn/index/memory/NativeMemoryEntryContext.java 100.00% <ø> (ø)
...main/java/org/opensearch/knn/jni/FaissService.java 85.71% <ø> (ø)
...c/main/java/org/opensearch/knn/jni/JNIService.java 85.71% <ø> (ø)
...g/opensearch/knn/plugin/script/KNNScoreScript.java 100.00% <ø> (ø)
...arch/knn/plugin/script/KNNScoringScriptEngine.java 66.66% <0.00%> (ø)
... and 174 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! THanks

@naveentatikonda naveentatikonda merged commit 55a52a8 into opensearch-project:1.3 Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants