Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Rachet to fix failing build #648

Merged

Conversation

naveentatikonda
Copy link
Member

Signed-off-by: Naveen [email protected]

Description

Get rid of rachet and apply spotless on every PR before raising it like in main branch. Making this change to fix the OS distribution build failure

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':spotlessCheck'.
> Could not create task ':spotlessJavaCheck'.
   > Could not create task ':spotlessJava'.
      > No such reference 'origin/1.x'

Issues Resolved

#647

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda naveentatikonda added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Dec 5, 2022
@naveentatikonda naveentatikonda requested a review from a team December 5, 2022 18:46
@martin-gaievski
Copy link
Member

Do we need to backport it to 1.3?

@naveentatikonda
Copy link
Member Author

Do we need to backport it to 1.3?

Yes, we need to backport it. The backport workflow in 1.x branch seems to be outdated and is not working. I will fix the workflow and for now will backport it manually

@naveentatikonda naveentatikonda merged commit 4488fbd into opensearch-project:1.x Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v1.3.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants