Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from CMakeLists.txt #325

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

jmazanec15
Copy link
Member

Description

Removes setting of versions in CMake and pushed them to build.gradle. Version is used in CMake for building RPM/DEB with CPack. Currently, the CPack logic is not used in the OpenSearch project. Not removing because it may be used by others that build the plugin separately.

In addition, PR bumps numpy to fix whitesource failures. This is in line with 1.x branch.

Issues Resolved

#82

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Removes hardcoding version in CMakeLists and configures build.gradle to
pass in OpenSearch version.

Signed-off-by: John Mazanec <[email protected]>
Signed-off-by: John Mazanec <[email protected]>
@jmazanec15 jmazanec15 added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Mar 18, 2022
@jmazanec15 jmazanec15 requested a review from a team March 18, 2022 18:58
@martin-gaievski
Copy link
Member

I wonder how did we set KNN_PLUGIN_VERSION before?
Another point - do we need to document this new way of setting it via gradle build script, maybe in dev guide?

@jmazanec15
Copy link
Member Author

@martin-gaievski KNN_PLUGIN_VERSION was manually updated with each release as default. No need to update docs. Its already taken care of in gradle. No changes for user.

@jmazanec15 jmazanec15 merged commit c63bef5 into opensearch-project:main Mar 18, 2022
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 30, 2022
Removes hardcoding version in CMakeLists and configures build.gradle to
pass in OpenSearch version. 

Updates numpy to fix whitesource check.

Signed-off-by: John Mazanec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants