Skip to content

Commit

Permalink
Remove version from CMakeLists.txt (opensearch-project#325)
Browse files Browse the repository at this point in the history
Removes hardcoding version in CMakeLists and configures build.gradle to
pass in OpenSearch version. 

Updates numpy to fix whitesource check.

Signed-off-by: John Mazanec <[email protected]>
  • Loading branch information
jmazanec15 authored Mar 18, 2022
1 parent ba64c68 commit 38f1c23
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion benchmarks/perf-tool/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ h5py==3.3.0
# via -r requirements.in
idna==3.2
# via requests
numpy==1.22.0
numpy==1.22.1
# via
# -r requirements.in
# h5py
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ opensearch_tmp_dir.mkdirs()

task cmakeJniLib(type:Exec) {
workingDir 'jni'
commandLine 'cmake', '.'
commandLine 'cmake', '.', "-DKNN_PLUGIN_VERSION=${opensearch_version}"
}

task buildJniLib(type:Exec) {
Expand Down
3 changes: 2 additions & 1 deletion jni/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@ else()
message(FATAL_ERROR "Unable to run on system: ${CMAKE_SYSTEM_NAME}")
endif()

# By default, set to 0.0.0
if(NOT KNN_PLUGIN_VERSION)
set(KNN_PLUGIN_VERSION "1.3.0.0")
set(KNN_PLUGIN_VERSION "0.0.0")
endif()

# Set architecture specific variables
Expand Down

0 comments on commit 38f1c23

Please sign in to comment.