Fix locale in FaissTests #1082
Merged
Fix locale in FaissTests #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1082 +/- ##
============================================
- Coverage 85.09% 85.03% -0.07%
Complexity 1184 1184
============================================
Files 159 159
Lines 4811 4811
Branches 433 433
============================================
- Hits 4094 4091 -3
- Misses 521 524 +3
Partials 196 196 |
martin-gaievski
approved these changes
Aug 31, 2023
naveentatikonda
approved these changes
Aug 31, 2023
jmazanec15
added a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Aug 31, 2023
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added a commit
to jmazanec15/k-NN-1
that referenced
this pull request
Aug 31, 2023
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: John Mazanec <[email protected]>
jmazanec15
added a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1077 failure. Change was introduced in #1074 . Adds locale as root when comparing strings to prevent unexpected string errors.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.