[Backport 2.10] Update Faiss engine to allow PQ and HNSW #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
jmazanec15
changed the title
Updates faiss engine to enable hnsw and faiss to work together. For HNSW, code_size must be equal to 8 (refer to facebookresearch/faiss#3027). Therefore, the index description string "HNSW32,PQXxY" does not work. Only "HNSW32,PQX" ends up working. Additionally, adds several unit tests and integration tests in order to validate the functionality. Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
backport/backport-1074-to-2.10
branch
from
cebc358 to
3df15d9
Compare
Codecov Report
@@ Coverage Diff @@
## 2.10 #1077 +/- ##
============================================
+ Coverage 85.03% 85.06% +0.03%
- Complexity 1159 1162 +3
============================================
Files 154 154
Lines 4730 4753 +23
Branches 434 434
============================================
+ Hits 4022 4043 +21
- Misses 513 514 +1
- Partials 195 196 +1
|
vibrantvarun
approved these changes
Aug 31, 2023
|
@jmazanec15 Some Faiss_tests are failing on MacOS |
navneet1v
previously approved these changes
Aug 31, 2023
|
@jmazanec15 mac os build and test is failing |
|
Looks like a locale issue. Let me fix |
Signed-off-by: John Mazanec <[email protected]>
martin-gaievski
approved these changes
Aug 31, 2023
navneet1v
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #1074 to 2.10
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.