Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled the IVF algorithm to work with Filters of K-NN Query. #1013

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

navneet1v
Copy link
Collaborator

@navneet1v navneet1v commented Jul 31, 2023

Description

Enabled the IVF algorithm to work with Filters of K-NN Query.

Issues Resolved

#903

Current main branch build is broken. I will forward port that change once the issue is resolved.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v navneet1v added the Features Introduces a new unit of functionality that satisfies a requirement label Jul 31, 2023
@navneet1v navneet1v added Enhancements Increases software capabilities beyond original client specifications enhancement and removed Features Introduces a new unit of functionality that satisfies a requirement labels Jul 31, 2023
@navneet1v navneet1v added the v2.10.0 Issues targeting release v2.10.0 label Jul 31, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1013 (9b6eb5d) into 2.x (ae9c9f4) will decrease coverage by 0.04%.
The diff coverage is 70.00%.

❗ Current head 9b6eb5d differs from pull request most recent head 271047e. Consider uploading reports for the commit 271047e to get more accurate results

@@             Coverage Diff              @@
##                2.x    #1013      +/-   ##
============================================
- Coverage     85.16%   85.13%   -0.04%     
- Complexity     1145     1148       +3     
============================================
  Files           154      154              
  Lines          4693     4702       +9     
  Branches        426      428       +2     
============================================
+ Hits           3997     4003       +6     
- Misses          504      506       +2     
- Partials        192      193       +1     
Files Changed Coverage Δ
...java/org/opensearch/knn/index/query/KNNWeight.java 85.62% <70.00%> (-1.13%) ⬇️

@navneet1v navneet1v merged commit 85c5a3a into opensearch-project:2.x Jul 31, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2023
navneet1v added a commit to navneet1v/k-NN that referenced this pull request Aug 1, 2023
navneet1v added a commit that referenced this pull request Aug 1, 2023
…#1015)

Signed-off-by: Navneet Verma <[email protected]>
(cherry picked from commit 85c5a3a)

Co-authored-by: Navneet Verma <[email protected]>
navneet1v added a commit that referenced this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.9 enhancement Enhancements Increases software capabilities beyond original client specifications v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants