Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path of REST APIs for 'Sample Extension Plugin' and naming convension in filename and comments #25

Merged
merged 6 commits into from
May 20, 2021

Conversation

tlfeng
Copy link
Contributor

@tlfeng tlfeng commented May 19, 2021

Description

  • Change the path of REST APIs for "Sample Extension Plugin". "Rest APIs Backward Compatibility" is not applied, because the plugin is only a sample to show how to use Job Scheduler SPI.
  • Rename "kibana" and "Elasticsearch" in the comments of "Sample Extension Plugin"
  • Rename the mapping definition file for the lock index of Job Scheduler opendistro_job_scheduler_lock.json to opensearch_job_scheduler_lock.json

Note:

  • The name of the lock index ".opendistro-job-scheduler-lock" is not changed.
  • The 2 line breaks in SampleExtensionRestHandler.java is due to the "140 characters" restriction of "Checkstyle rule".

Issues Resolved

a part of #22

Check List

- [ ] New functionality includes testing.

  • All tests pass
    - [ ] New functionality has been documented.
    - [ ] New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng changed the title Change path of REST APIs for 'Sample Extension Plugin' and naming convension in resource file name and comments Change path of REST APIs and naming convension in filename and comments for 'Sample Extension Plugin' May 19, 2021
@tlfeng tlfeng changed the title Change path of REST APIs and naming convension in filename and comments for 'Sample Extension Plugin' Change path of REST APIs for 'Sample Extension Plugin' and naming convension in filename and comments May 19, 2021
@bowenlan-amzn bowenlan-amzn merged commit 4bba09d into opensearch-project:main May 20, 2021
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
…vension in filename and comments (opensearch-project#25)

* Rename mapping definition file for job scheduler lock index

* Rename Elasticsearch to OpenSearch in comments for Sample-extension-plugin

* Rename Rest API and 'kibana' in the comments for sample-extension-plugin

Signed-off-by: Tianli Feng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants