Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure job-scheduler can be a drop-in replacement for job-scheduler working in ODFE 1.13 and ES 7.10.x for v1.0.0 #22

Closed
6 of 8 tasks
dblock opened this issue May 7, 2021 · 8 comments

Comments

@dblock
Copy link
Member

dblock commented May 7, 2021

Coming from opensearch-project/OpenSearch#671 and opensearch-project/opensearch-plugins#12.

@dblock dblock added enhancement New feature or request backwards-compatibility and removed enhancement New feature or request labels May 7, 2021
@dblock
Copy link
Member Author

dblock commented May 11, 2021

Settings done, #20

@tlfeng
Copy link
Contributor

tlfeng commented May 18, 2021

I will take care of this today. Guide to follow with: https://github.com/opensearch-project/opensearch-plugins/blob/main/UPGRADING.md

@tlfeng
Copy link
Contributor

tlfeng commented May 20, 2021

With above PRs merged,
Rest APIs, variables, namespaces, and remaining identifiers have been renamed.
No classes and methods to be renamed.

@dblock
Copy link
Member Author

dblock commented May 20, 2021

@tlfeng What's left for this issue?

@tlfeng
Copy link
Contributor

tlfeng commented May 20, 2021

Hi dB, Indices renaming and testing in the real scenario are left.

@dblock
Copy link
Member Author

dblock commented May 20, 2021

We've decided not to rename indices.

Integration tests need to run against rc1 artifact (coming soon). That probably requires a change in CI workflow once that's available.

@dblock dblock assigned skkosuri-amzn and tlfeng and unassigned skkosuri-amzn May 26, 2021
@dblock
Copy link
Member Author

dblock commented May 26, 2021

@tlfeng are we done here? close if so

@tlfeng
Copy link
Contributor

tlfeng commented May 26, 2021

Hi dB, I think it can be closed. Although you found the 'rc1' qualifier is not declared in the CI workflow (#32), it doesn't impact the compatibility of the plugin. We can also close after that is resolved.

@dblock dblock closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants