Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses custom plugin to publish zips to maven #182

Merged
merged 3 commits into from
May 12, 2022
Merged

Uses custom plugin to publish zips to maven #182

merged 3 commits into from
May 12, 2022

Conversation

downsrob
Copy link
Contributor

@downsrob downsrob commented May 11, 2022 •
edited
Loading

Signed-off-by: Clay Downs [email protected]

Description

Uses custom plugin to publish zips to maven

Issues Resolved

#175

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@downsrob downsrob marked this pull request as ready for review May 11, 2022 17:30
@downsrob downsrob requested a review from a team May 11, 2022 17:30
prudhvigodithi
prudhvigodithi reviewed May 11, 2022
View reviewed changes
scripts/build.sh Outdated
@@ -73,6 +73,7 @@ mkdir -p $OUTPUT/maven/org/opensearch
cp -r ./build/local-staging-repo/org/opensearch/. $OUTPUT/maven/org/opensearch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @downsrob you should be adding cp -r ./build/local-staging-repo/org/opensearch/. $OUTPUT/maven/org/opensearch at the end after running publishPluginZipPublicationToZipStagingRepository task as even the zips are also copied to local $OUTPUT folder
Example as
https://github.com/prudhvigodithi/job-scheduler/blob/gradleplugin/scripts/build.sh#L78-L83

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, let me know if that is what you wanted. Once again I will say that it seems that you have already done this work and I feel that you could have raised this PR with far less effort.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @downsrob, this is the setting and expectation from the custom plugin end and looks good now.

@downsrob
updates build.sh
930ba52 
Signed-off-by: Clay Downs <[email protected]>
@prudhvigodithi prudhvigodithi mentioned this pull request May 12, 2022
Closed
@sbcd90 sbcd90 self-requested a review May 12, 2022 20:10
@downsrob downsrob merged commit 49f2c83 into opensearch-project:main May 12, 2022
@downsrob downsrob deleted the zips-to-maven branch May 12, 2022 20:14
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
@downsrob
Uses custom plugin to publish zips to maven (opensearch-project#182)
477d659 
* Uses custom plugin to publish zips to maven

Signed-off-by: Clay Downs <[email protected]>

* Removes license and developers

Signed-off-by: Clay Downs <[email protected]>

* updates build.sh

Signed-off-by: Clay Downs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenlan-amzn bowenlan-amzn bowenlan-amzn approved these changes

@prudhvigodithi prudhvigodithi prudhvigodithi approved these changes

@sbcd90 sbcd90 sbcd90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@downsrob @sbcd90 @prudhvigodithi @bowenlan-amzn