-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish plugin zips to maven repo #525
Comments
@sean-zheng-amazon @ylwu-amzn Can you please make the necessary changes as listed on the document to support publishing your zips to Maven? |
@bbarani @prudhvigodithi AD doesn't have the a build.sh file currently so this requires more than just a few lines from my understanding on AD side. Is it as easy as copying the same build.sh script that some plugins already have? |
Hey @amitgalitz you can check example of job-scheduler PR, also there is a proposal to add a setting in default build.sh for the plugins that does not manage the build scripts, But I would suggest you to go ahead and create a build.sh from the AD plugin. |
Hey @sean-zheng-amazon @amitgalitz @ylwu-amzn, just following up to see if |
Hey @sean-zheng-amazon @amitgalitz @ylwu-amzn, just following up again :) |
@amitgalitz @sean-zheng-amazon Can you please update the status on changes to your build script to publish plugin zip to maven? |
@bbarani I'll have a PR out for this today |
Description
With existing setup the plugin jars are only published to maven repo, but not the generated plugin zips.
Related META issue
opensearch-project/opensearch-build#1916
Current Behavior
Existing all maven publications target the jar files to publish to maven, but not the generated distribution zips.
Expected Behavior
Along with plugin jars, plugin zips should also be published to maven repo with right maven coordinates, so user can download these plugins using dependancy model.
Steps To Reproduce
Proposed solution
A custom gradle plugin solution that can create the publication task for the zips to get published to local staging maven repo with right maven coordinates.
Add/Configure the custom gradle plugin openseearch.pluginzip to the gradle project and test the generated plugin zip's to upload to local maven repo.
More details on how to use the Plugin:
https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#opensearchpluginzip
The text was updated successfully, but these errors were encountered: