Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish plugin zips to maven repo #525

Closed
Tracked by #1916
prudhvigodithi opened this issue Apr 28, 2022 · 7 comments · Fixed by #594
Closed
Tracked by #1916

Publish plugin zips to maven repo #525

prudhvigodithi opened this issue Apr 28, 2022 · 7 comments · Fixed by #594

Comments

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Apr 28, 2022

Description

With existing setup the plugin jars are only published to maven repo, but not the generated plugin zips.

Related META issue

opensearch-project/opensearch-build#1916

Current Behavior

Existing all maven publications target the jar files to publish to maven, but not the generated distribution zips.

Expected Behavior

Along with plugin jars, plugin zips should also be published to maven repo with right maven coordinates, so user can download these plugins using dependancy model.

Steps To Reproduce

  1. Run the gradle assemble task that outputs jar and zips.
  2. Using build setup the jars are published to local staging maven repo.
  3. Zip's are just added to distribution's folder during build runtime.
  4. Finally once build is done, just the jar files are added to local maven repo and updates to the manifest file, but not the zips.

Proposed solution

A custom gradle plugin solution that can create the publication task for the zips to get published to local staging maven repo with right maven coordinates.
Add/Configure the custom gradle plugin openseearch.pluginzip to the gradle project and test the generated plugin zip's to upload to local maven repo.
More details on how to use the Plugin:
https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#opensearchpluginzip

@bbarani
Copy link
Member

bbarani commented May 11, 2022

@sean-zheng-amazon @ylwu-amzn Can you please make the necessary changes as listed on the document to support publishing your zips to Maven?

@amitgalitz
Copy link
Member

@bbarani @prudhvigodithi AD doesn't have the a build.sh file currently so this requires more than just a few lines from my understanding on AD side. Is it as easy as copying the same build.sh script that some plugins already have?

@prudhvigodithi
Copy link
Member Author

Hey @amitgalitz you can check example of job-scheduler PR, also there is a proposal to add a setting in default build.sh for the plugins that does not manage the build scripts, But I would suggest you to go ahead and create a build.sh from the AD plugin.
@dblock @bbarani @peterzhuamazon

@prudhvigodithi
Copy link
Member Author

Hey @sean-zheng-amazon @amitgalitz @ylwu-amzn, just following up to see if opensearch.pluginzip is integrated, if not please make the necessary changes to add opensearch.pluginzip to support publishing your zips to Maven.

@prudhvigodithi
Copy link
Member Author

Hey @sean-zheng-amazon @amitgalitz @ylwu-amzn, just following up again :)
Found another example where build.sh was added as part of this PR opensearch-project/index-management#366

@bbarani
Copy link
Member

bbarani commented Jun 27, 2022

@amitgalitz @sean-zheng-amazon Can you please update the status on changes to your build script to publish plugin zip to maven?

@amitgalitz
Copy link
Member

@bbarani I'll have a PR out for this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants