[Backport 1.3] Fix metadata migration logic error when update setting call failed #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
) If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: Bowen Lan <[email protected]> (cherry picked from commit f4a3938)
bowenlan-amzn
force-pushed
the
backport/backport-328-to-1.3
branch
from
c97f173 to
91ac87f
Compare
Codecov Report
@@ Coverage Diff @@
## 1.3 #330 +/- ##
============================================
+ Coverage 75.64% 75.90% +0.26%
- Complexity 2011 2014 +3
============================================
Files 253 253
Lines 11467 11473 +6
Branches 1815 1816 +1
============================================
+ Hits 8674 8709 +35
+ Misses 1763 1737 -26
+ Partials 1030 1027 -3
Continue to review full report at Codecov.
|
bowenlan-amzn
approved these changes
Apr 17, 2022
downsrob
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f4a3938 from #328