Fix metadata migration logic error when update setting call failed #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: bowenlan-amzn <[email protected]>
bowenlan-amzn
force-pushed
the
mdmigrationfix
branch
from
f3ea27f to
53b7427
Compare
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
============================================
- Coverage 76.71% 76.57% -0.14%
- Complexity 2044 2046 +2
============================================
Files 253 253
Lines 11636 11642 +6
Branches 1807 1808 +1
============================================
- Hits 8926 8915 -11
- Misses 1742 1762 +20
+ Partials 968 965 -3
Continue to review full report at Codecov.
|
|
Can we also include the exists check in template migration? - |
thalurur
reviewed
Apr 13, 2022
src/main/kotlin/org/opensearch/indexmanagement/indexstatemanagement/MetadataService.kt
Show resolved
Hide resolved
Since template migration migrates from index template, config index not existing doesn't really mean there is no related index template, so I didn't add this check this time. |
thalurur
approved these changes
Apr 14, 2022
downsrob
approved these changes
Apr 14, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
) If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit f4a3938)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
) If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit f4a3938)
bowenlan-amzn
added a commit
that referenced
this pull request
Apr 16, 2022
) If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: Bowen Lan <[email protected]> (cherry picked from commit f4a3938)
bowenlan-amzn
added a commit
that referenced
this pull request
Apr 16, 2022
) If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: Bowen Lan <[email protected]> (cherry picked from commit f4a3938)
bowenlan-amzn
added a commit
that referenced
this pull request
Apr 17, 2022
) (#329) If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: Bowen Lan <[email protected]> (cherry picked from commit f4a3938) Co-authored-by: Bowen Lan <[email protected]>
bowenlan-amzn
added a commit
that referenced
this pull request
Apr 17, 2022
) (#330) If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: Bowen Lan <[email protected]> (cherry picked from commit f4a3938) Co-authored-by: Bowen Lan <[email protected]>
wuychn
pushed a commit
to ochprince/index-management
that referenced
this pull request
Mar 16, 2023
…pensearch-project#328) If update setting to 1 failed, runTimeCounter shouldn't be increased. Otherwise it will increase to be larger than 10, and start to update setting to -1 which is unwanted. Signed-off-by: bowenlan-amzn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If update setting to 1 failed,
runTimeCountershouldn't be increased.Otherwise it will increase to be larger than 10, and start to update
setting to -1 in the end which is unwanted.
Signed-off-by: bowenlan-amzn [email protected]
Issue #, if available:
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.