-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exports is undefined
#826
Fix exports is undefined
#826
Conversation
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 63.37% 63.36% -0.01%
==========================================
Files 341 341
Lines 11545 11553 +8
Branches 2108 2112 +4
==========================================
+ Hits 7317 7321 +4
- Misses 3654 3658 +4
Partials 574 574 |
I don't believe this is the best solution. While it does solve the problem caused by the Doing import {
AppMountParameters,
CoreSetup,
CoreStart,
- DEFAULT_APP_CATEGORIES,
Plugin,
PluginInitializerContext,
} from "../../../src/core/public";
+import { DEFAULT_APP_CATEGORIES } from "../../../src/core/utils/default_app_categories"; in https://github.com/opensearch-project/index-management-dashboards-plugin/blob/main/public/plugin.ts, avoids bundling all the unnecessary code from |
Based on the suggestion of @AMoo-Miki #834 (comment), will remove the babel override of this project babel.config.js for build and use default config from opensearch-dashboard we still need this file for |
cdecfab
to
57fd573
Compare
I made a bunch of changes to OSD as well to break the factors that contributed to this problem. |
…-commonjs Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
57fd573
to
73c7b4e
Compare
* Add allowTopLevelThis=true option for @babel/plugin-transform-modules-commonjs Signed-off-by: Hailong Cui <[email protected]> * remove override babel.config.js for build Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit be25b8b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add allowTopLevelThis=true option for @babel/plugin-transform-modules-commonjs * remove override babel.config.js for build --------- (cherry picked from commit be25b8b) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add allowTopLevelThis=true option for @babel/plugin-transform-modules-commonjs * remove override babel.config.js for build --------- (cherry picked from commit be25b8b) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 639df0d)
* Add allowTopLevelThis=true option for @babel/plugin-transform-modules-commonjs * remove override babel.config.js for build --------- (cherry picked from commit be25b8b) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 639df0d) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: bowenlan-amzn <[email protected]>
Description
Remove babel override for build and keep it for unit test, based on that add a condition in
babel.config.js
file.Issues Resolved
related to #741
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.