Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move index management from plugin section to management section #741

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented May 17, 2023

Description

Move Index Management and Snapshot Management from plugins section into Control center(original Management) section

Issues Resolved

#758
opensearch-project/OpenSearch-Dashboards#4133

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Hailong-am Hailong-am changed the title move ism into control center Move index management from plugin section to management section Jun 19, 2023
@Hailong-am Hailong-am force-pushed the feature/navigation branch 3 times, most recently from de9d31c to 58852a4 Compare June 19, 2023 08:09
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #741 (10588ce) into main (13fb97f) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   63.40%   63.37%   -0.03%     
==========================================
  Files         340      341       +1     
  Lines       11540    11545       +5     
  Branches     2238     2239       +1     
==========================================
  Hits         7317     7317              
- Misses       3649     3654       +5     
  Partials      574      574              

see 2 files with indirect coverage changes

@Hailong-am Hailong-am force-pushed the feature/navigation branch from fc26f2e to 10588ce Compare July 5, 2023 03:50
@xluo-aws xluo-aws merged commit 4352f54 into opensearch-project:main Jul 10, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-741-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4352f54c564d02d36ce6b7b412a9875d6254ddb8
# Push it to GitHub
git push --set-upstream origin backport/backport-741-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-741-to-2.x.

Hailong-am added a commit to Hailong-am/index-management-dashboards-plugin that referenced this pull request Jul 10, 2023
…search-project#741)

* Move index management into management section

Signed-off-by: Hailong Cui <[email protected]>

* Remove plugins pages for management overview registration

Signed-off-by: Hailong Cui <[email protected]>

* wording changes

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 4352f54)
Hailong-am added a commit to Hailong-am/index-management-dashboards-plugin that referenced this pull request Jul 10, 2023
…search-project#741)

* Move index management into management section

Signed-off-by: Hailong Cui <[email protected]>

* Remove plugins pages for management overview registration

Signed-off-by: Hailong Cui <[email protected]>

* wording changes

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 4352f54)
xluo-aws pushed a commit that referenced this pull request Jul 11, 2023
#805)

* Move index management into management section

Signed-off-by: Hailong Cui <[email protected]>

* Remove plugins pages for management overview registration

Signed-off-by: Hailong Cui <[email protected]>

* wording changes

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 4352f54)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-741-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4352f54c564d02d36ce6b7b412a9875d6254ddb8
# Push it to GitHub
git push --set-upstream origin backport/backport-741-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport/backport-741-to-2.9.

Hailong-am added a commit to Hailong-am/index-management-dashboards-plugin that referenced this pull request Jul 17, 2023
…search-project#741)

* Move index management into management section

Signed-off-by: Hailong Cui <[email protected]>

* Remove plugins pages for management overview registration

Signed-off-by: Hailong Cui <[email protected]>

* wording changes

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 4352f54)
Hailong-am added a commit that referenced this pull request Jul 17, 2023
#818)

* Move index management into management section

Signed-off-by: Hailong Cui <[email protected]>

* Remove plugins pages for management overview registration

Signed-off-by: Hailong Cui <[email protected]>

* wording changes

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 4352f54)
Hailong-am added a commit to Hailong-am/index-management-dashboards-plugin that referenced this pull request Jul 19, 2023
@Hailong-am Hailong-am deleted the feature/navigation branch July 24, 2023 05:28
@Hailong-am Hailong-am mentioned this pull request Jul 24, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants