-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inaccurate pre-check in shrink index page #570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Change some wording in shrink index page Signed-off-by: gaobinlong <[email protected]>
gaobinlong
changed the title
Remove inaccurate pre-check in shrink index page (#558)
Remove inaccurate pre-check in shrink index page
Jan 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
===========================================
+ Coverage 49.67% 59.70% +10.03%
===========================================
Files 195 268 +73
Lines 6225 8863 +2638
Branches 1023 1616 +593
===========================================
+ Hits 3092 5292 +2200
- Misses 2910 3177 +267
- Partials 223 394 +171
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hailong-am
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SuZhou-Joe
approved these changes
Jan 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
Change some wording in shrink index page Signed-off-by: gaobinlong <[email protected]> Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 216ca44)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
Change some wording in shrink index page Signed-off-by: gaobinlong <[email protected]> Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 216ca44)
gaobinlong
added a commit
that referenced
this pull request
Jan 12, 2023
Change some wording in shrink index page Signed-off-by: gaobinlong <[email protected]> Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 216ca44) Co-authored-by: gaobinlong <[email protected]>
gaobinlong
added a commit
that referenced
this pull request
Jan 12, 2023
Change some wording in shrink index page Signed-off-by: gaobinlong <[email protected]> Signed-off-by: gaobinlong <[email protected]> (cherry picked from commit 216ca44) Co-authored-by: gaobinlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some minor changes in the shrink index page:
index.routing.allocation.require._*
or not, if not a warning will be shown in the page, but this pre-check is not accurate because if the cluster has only one node or the settingindex.number_of_replicas
of the source index is equal to the number of nodes minus 1 , then users do not need to allocate a copy of every shard to one node, so we'd better remove it.Green
togreen
in the error message.Issues Resolved
#558
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.