Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inaccurate pre-check in shrink index page #570

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Jan 12, 2023

Description

There are some minor changes in the shrink index page:

  1. Remove inaccurate pre-check, when a copy of every shard of the source index do not reside on the same node, then shrink api call will fail, currently we have checked the index settings before users click the shrink button to see whether the source index contains a index setting like index.routing.allocation.require._* or not, if not a warning will be shown in the page, but this pre-check is not accurate because if the cluster has only one node or the setting index.number_of_replicas of the source index is equal to the number of nodes minus 1 , then users do not need to allocate a copy of every shard to one node, so we'd better remove it.
  2. Change some wording in the page, like change Green to green in the error message.

Issues Resolved

#558

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

)

Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>
@gaobinlong gaobinlong requested a review from a team January 12, 2023 08:55
@gaobinlong gaobinlong changed the title Remove inaccurate pre-check in shrink index page (#558) Remove inaccurate pre-check in shrink index page Jan 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #570 (5164cba) into main (d3d8e6f) will increase coverage by 10.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #570       +/-   ##
===========================================
+ Coverage   49.67%   59.70%   +10.03%     
===========================================
  Files         195      268       +73     
  Lines        6225     8863     +2638     
  Branches     1023     1616      +593     
===========================================
+ Hits         3092     5292     +2200     
- Misses       2910     3177      +267     
- Partials      223      394      +171     
Impacted Files Coverage Δ
...oards-plugin/public/pages/Indices/utils/helpers.ts 84.12% <0.00%> (-15.88%) ⬇️
...gement-dashboards-plugin/public/utils/constants.ts 95.23% <0.00%> (-4.77%) ⬇️
...ublic/pages/Indices/containers/Indices/Indices.tsx 82.50% <0.00%> (-3.62%) ⬇️
...ement-dashboards-plugin/public/pages/Main/Main.tsx 6.32% <0.00%> (-1.08%) ⬇️
...-dashboards-plugin/public/index_management_app.tsx 6.25% <0.00%> (-0.42%) ⬇️
...p/containers/CreateRollupForm/CreateRollupForm.tsx 69.86% <0.00%> (-0.36%) ⬇️
...ndex-management-dashboards-plugin/public/plugin.ts 0.00% <0.00%> (ø)
...ex-management-dashboards-plugin/utils/constants.ts 100.00% <0.00%> (ø)
...ic/components/ContentPanel/ContentPanelActions.tsx 100.00% <0.00%> (ø)
...atePolicy/components/FlyoutFooter/FlyoutFooter.tsx 66.66% <0.00%> (ø)
... and 86 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaobinlong gaobinlong merged commit 216ca44 into opensearch-project:main Jan 12, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 216ca44)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 216ca44)
gaobinlong added a commit that referenced this pull request Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 216ca44)

Co-authored-by: gaobinlong <[email protected]>
gaobinlong added a commit that referenced this pull request Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 216ca44)

Co-authored-by: gaobinlong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants