Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink index operation: minor change after bugathon and review #558

Closed
gaobinlong opened this issue Jan 10, 2023 · 3 comments
Closed

Shrink index operation: minor change after bugathon and review #558

gaobinlong opened this issue Jan 10, 2023 · 3 comments
Assignees

Comments

@gaobinlong
Copy link
Contributor

gaobinlong commented Jan 10, 2023

There are some minor bugs after bugathon and team members' review, we need to fix them.

@gaobinlong
Copy link
Contributor Author

These work need to be done for the shrink index page:

  1. Add a space before the learn more link.
  2. Modify the format of the title.

@gaobinlong
Copy link
Contributor Author

There is a pre-check which is not accurate for the shrink index operation, when a copy of every shard of the source index do not reside on the same node, currently a warning will be shown when the shrink index page appears, but the check is not accurate because there are no direct way to check whether a copy of every shard reside on the same node. So the check will be removed, and the OpenSearch server will return any error message when then shrink api call fails.

@gaobinlong
Copy link
Contributor Author

Besides, there are some wording need to be correct, such as change Green to green in the error message.

gaobinlong added a commit to gaobinlong/index-management-dashboards-plugin that referenced this issue Jan 12, 2023
)

Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>
gaobinlong added a commit that referenced this issue Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 216ca44)
opensearch-trigger-bot bot pushed a commit that referenced this issue Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 216ca44)
gaobinlong added a commit that referenced this issue Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 216ca44)

Co-authored-by: gaobinlong <[email protected]>
gaobinlong added a commit that referenced this issue Jan 12, 2023
Change some wording in shrink index page

Signed-off-by: gaobinlong <[email protected]>

Signed-off-by: gaobinlong <[email protected]>
(cherry picked from commit 216ca44)

Co-authored-by: gaobinlong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant