Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reindex operation into indices page #513

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Dec 23, 2022

Description

support reindex operation on indexes page, https://opensearch.org/docs/latest/opensearch/reindex-data/

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* enable fullwidth for JSON editor

Signed-off-by: Hailong Cui <[email protected]>

* update width of import settings & mappings

Signed-off-by: Hailong Cui <[email protected]>

* wording change

Signed-off-by: Hailong Cui <[email protected]>

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
@Hailong-am Hailong-am requested a review from a team December 23, 2022 15:09
@Hailong-am Hailong-am added index-operation v2.5.0 'Issues and PRs related to version v2.5.0' labels Dec 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #513 (0b6746f) into index-operation-common (f3fb5d9) will increase coverage by 3.93%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##           index-operation-common     #513      +/-   ##
==========================================================
+ Coverage                   52.21%   56.15%   +3.93%     
==========================================================
  Files                         219      234      +15     
  Lines                        6885     7845     +960     
  Branches                     1160     1394     +234     
==========================================================
+ Hits                         3595     4405     +810     
- Misses                       3023     3108      +85     
- Partials                      267      332      +65     
Impacted Files Coverage Δ
...oards-plugin/public/pages/Indices/utils/helpers.ts 40.32% <0.00%> (-59.68%) ⬇️
...ublic/pages/Indices/containers/Indices/Indices.tsx 82.50% <0.00%> (-3.62%) ⬇️
...atePolicy/components/FlyoutFooter/FlyoutFooter.tsx 66.66% <0.00%> (ø)
...components/CreateIndexFlyout/CreateIndexFlyout.tsx 75.00% <0.00%> (ø)
.../ReindexAdvancedOptions/ReindexAdvancedOptions.tsx 90.90% <0.00%> (ø)
...IndexDetail/containers/IndexDetail/IndexDetail.tsx 74.74% <0.00%> (ø)
...rds-plugin/public/pages/Reindex/utils/constants.ts 100.00% <0.00%> (ø)
...c/pages/CreateIndex/containers/IndexForm/index.tsx 90.27% <0.00%> (ø)
...eateIndex/components/MappingLabel/MappingLabel.tsx 76.56% <0.00%> (ø)
...eateIndex/components/IndexMapping/IndexMapping.tsx 79.83% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Hailong Cui <[email protected]>
xluo-aws
xluo-aws previously approved these changes Dec 24, 2022
@amsiglan
Copy link
Contributor

amsiglan commented Jan 8, 2023

Please add description for the changes in this PR and break it down to smaller PRs

@amsiglan
Copy link
Contributor

amsiglan commented Jan 8, 2023

@Hailong-am @SuZhou-Joe The files in this PR and #509 seem to overlap, can we please consolidate the changes into 1 PR?

@Hailong-am
Copy link
Collaborator Author

@Hailong-am @SuZhou-Joe The files in this PR and #509 seem to overlap, can we please consolidate the changes into 1 PR?

Yes, there have some overlaps as reindex page have dependencies on create index page. To make UT and E2E test pass, i have include the dependency into this PR also. For review, you can focus on public/pages/Reindex folder

@Hailong-am Hailong-am self-assigned this Jan 9, 2023
@Hailong-am Hailong-am changed the title Index operation reindex Add reindex operation into indices page Jan 10, 2023
@xluo-aws xluo-aws mentioned this pull request Jan 10, 2023
1 task
@Hailong-am Hailong-am closed this Jan 11, 2023
@Hailong-am Hailong-am deleted the index-operation-reindex branch July 24, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
index-operation v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants