-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge index management to index-operation-common #509
Merge index management to index-operation-common #509
Conversation
Signed-off-by: suzhou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## index-operation-common #509 +/- ##
==========================================================
+ Coverage 52.21% 55.52% +3.31%
==========================================================
Files 219 231 +12
Lines 6885 7663 +778
Branches 1160 1347 +187
==========================================================
+ Hits 3595 4255 +660
- Misses 3023 3098 +75
- Partials 267 310 +43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good overall. Please split big components into multiple files and move interfaces/helpers to their own files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with the technology here, so not many comments. I would like to see
- comments on any utility/shared functions
- when doing decomposition keep functions closer together
Signed-off-by: suzhou [email protected]
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.