Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge index management to index-operation-common #509

Conversation

SuZhou-Joe
Copy link
Member

Signed-off-by: suzhou [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: suzhou <[email protected]>
@SuZhou-Joe SuZhou-Joe requested a review from a team December 23, 2022 07:00
@SuZhou-Joe SuZhou-Joe self-assigned this Dec 23, 2022
@SuZhou-Joe SuZhou-Joe added v2.5.0 'Issues and PRs related to version v2.5.0' index-operation labels Dec 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #509 (8768452) into index-operation-common (f3fb5d9) will increase coverage by 3.31%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##           index-operation-common     #509      +/-   ##
==========================================================
+ Coverage                   52.21%   55.52%   +3.31%     
==========================================================
  Files                         219      231      +12     
  Lines                        6885     7663     +778     
  Branches                     1160     1347     +187     
==========================================================
+ Hits                         3595     4255     +660     
- Misses                       3023     3098      +75     
- Partials                      267      310      +43     
Impacted Files Coverage Δ
...oards-plugin/public/pages/Indices/utils/helpers.ts 40.32% <0.00%> (-59.68%) ⬇️
...ublic/pages/Indices/containers/Indices/Indices.tsx 82.50% <0.00%> (-3.62%) ⬇️
...lic/pages/Indices/containers/IndexDetail/index.tsx 80.00% <0.00%> (ø)
...IndexDetail/containers/IndexDetail/IndexDetail.tsx 74.00% <0.00%> (ø)
...ces/components/CloseIndexModal/CloseIndexModal.tsx 100.00% <0.00%> (ø)
...eateIndex/components/MappingLabel/MappingLabel.tsx 76.56% <0.00%> (ø)
...CreateIndex/components/IndexDetail/IndexDetail.tsx 82.11% <0.00%> (ø)
...CreateIndex/containers/CreateIndex/CreateIndex.tsx 100.00% <0.00%> (ø)
.../pages/Indices/containers/IndicesActions/index.tsx 89.18% <0.00%> (ø)
...c/pages/CreateIndex/containers/IndexForm/index.tsx 89.58% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

xluo-aws
xluo-aws previously approved these changes Dec 24, 2022
Signed-off-by: suzhou <[email protected]>
Signed-off-by: suzhou <[email protected]>
Copy link
Contributor

@amsiglan amsiglan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall. Please split big components into multiple files and move interfaces/helpers to their own files

Copy link

@awick awick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the technology here, so not many comments. I would like to see

  • comments on any utility/shared functions
  • when doing decomposition keep functions closer together

@xluo-aws xluo-aws mentioned this pull request Jan 10, 2023
1 task
@SuZhou-Joe SuZhou-Joe closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
index-operation v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants