Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] Allow user-defined labels on pvcs #600

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

simonstumpf
Copy link
Contributor

@simonstumpf simonstumpf commented Sep 19, 2024

Description

[Backport 1.x] Add support for user-defined labels on PVCs.

Issues Resolved

Closes #554
Backport #591

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simon Stumpf <[email protected]>
@prudhvigodithi
Copy link
Member

Thanks @simonstumpf, backport of #591.
Adding @peterzhuamazon

@prudhvigodithi
Copy link
Member

@simonstumpf can you please fix the failing CI's?
Thanks

@prudhvigodithi prudhvigodithi self-requested a review September 19, 2024 16:08
@peterzhuamazon
Copy link
Member

Not sure why is the failure tho, pinging @simonstumpf


Installing chart with values file 'charts/opensearch/ci/ci-rbac-enabled-values.yaml'...

Creating namespace 'opensearch-wh6i31dni7'...
>>> kubectl create namespace opensearch-wh6i31dni7
namespace/opensearch-wh6i31dni7 created
>>> helm install opensearch-wh6i31dni7 charts/opensearch --namespace opensearch-wh6i31dni7 --wait --values charts/opensearch/ci/ci-rbac-enabled-values.yaml --timeout 1000s
Error: The operation was canceled.

Thanks.

charts/opensearch/CHANGELOG.md Show resolved Hide resolved
charts/opensearch/CHANGELOG.md Outdated Show resolved Hide resolved
charts/opensearch/Chart.yaml Outdated Show resolved Hide resolved
@peterzhuamazon
Copy link
Member

I am fixing this and merging.

@peterzhuamazon peterzhuamazon merged commit 88052a9 into opensearch-project:1.x Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Enhancement][opensearch] Allow user-defined labels on pvcs
3 participants