Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][opensearch] Allow user-defined labels on pvcs #554

Closed
simonstumpf opened this issue Jul 2, 2024 · 8 comments · Fixed by #591 or #600
Closed

[Enhancement][opensearch] Allow user-defined labels on pvcs #554

simonstumpf opened this issue Jul 2, 2024 · 8 comments · Fixed by #591 or #600
Assignees
Labels
enhancement New feature or request

Comments

@simonstumpf
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Our PVCs get backuped based on a policy defined in the PVC label. However it's currently not possible to define additional labels for the PVC (instead the global labels are applied if .Values.persistence.labels.enabled is true).
Describe the solution you'd like
I'd like to define additional labels that are added besides the global labels.

Describe alternatives you've considered
I don't see another way of doing it.

Additional context

@simonstumpf simonstumpf added enhancement New feature or request untriaged Issues that have not yet been triaged labels Jul 2, 2024
@prudhvigodithi
Copy link
Member

[Triage]
I see the PR #555 is already created for this change, thanks for your contribution @simonstumpf.

@prudhvigodithi prudhvigodithi removed the untriaged Issues that have not yet been triaged label Jul 18, 2024
@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Engineering Effectiveness Board Jul 18, 2024
@peterzhuamazon peterzhuamazon changed the title [Enhancement][opensearch] [Enhancement][opensearch] Allow user-defined labels on pvcs Sep 16, 2024
@peterzhuamazon
Copy link
Member

Waiting for the backport to 1.x before closing this.

Thanks.

@simonstumpf
Copy link
Contributor Author

@peterzhuamazon
Thanks!
Should I merge my branch into the 1.x branch or the main?

@prudhvigodithi
Copy link
Member

Hey @simonstumpf please create a PR to 1.x branch.

@simonstumpf
Copy link
Contributor Author

@prudhvigodithi Im a little bit confused. I've created the PR, but there are too many changes? Do you see what I did wrong?

@prudhvigodithi
Copy link
Member

@simonstumpf you need to clone 1.x--> add your changes-->then please create the PR to 1.x.

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Sep 18, 2024

@prudhvigodithi Im a little bit confused. I've created the PR, but there are too many changes? Do you see what I did wrong?

Added steps here also closed that PR since it is messing up.
#599 (comment)

Thanks.

@peterzhuamazon
Copy link
Member

Resolved, closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
3 participants