Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Added an optional workflow_step param to the get workflow steps API #542

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2c6dfd5 from #538.

…538)

* Added optional step param to get the workflow steps API

Signed-off-by: Owais Kazi <[email protected]>

* Fixed api response

Signed-off-by: Owais Kazi <[email protected]>

* Added tests

Signed-off-by: Owais Kazi <[email protected]>

* Added CHANGELOG

Signed-off-by: Owais Kazi <[email protected]>

* Addressed PR comments

Signed-off-by: Owais Kazi <[email protected]>

* Added another test

Signed-off-by: Owais Kazi <[email protected]>

* Logged exception message

Signed-off-by: Owais Kazi <[email protected]>

---------

Signed-off-by: Owais Kazi <[email protected]>
(cherry picked from commit 2c6dfd5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.74%. Comparing base (2eb8769) to head (08b222d).

Files Patch % Lines
...work/transport/GetWorkflowStepTransportAction.java 66.66% 3 Missing ⚠️
.../flowframework/rest/RestGetWorkflowStepAction.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #542      +/-   ##
============================================
+ Coverage     73.10%   73.74%   +0.64%     
- Complexity      649      663      +14     
============================================
  Files            79       79              
  Lines          3294     3314      +20     
  Branches        257      263       +6     
============================================
+ Hits           2408     2444      +36     
+ Misses          773      756      -17     
- Partials        113      114       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 2540db6 into 2.x Feb 27, 2024
28 checks passed
@dbwiddis dbwiddis deleted the backport/backport-538-to-2.x branch February 27, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant