-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an optional workflow_step param to the get workflow steps API #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few suggestions to make it better.
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowStepAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStepTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/workflow/WorkflowStepFactory.java
Outdated
Show resolved
Hide resolved
2ce2189
to
aa240bb
Compare
aa240bb
to
84676b6
Compare
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStepTransportAction.java
Show resolved
Hide resolved
76a233b
to
baf7c95
Compare
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
Signed-off-by: Owais Kazi <[email protected]>
baf7c95
to
dd6e74b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
============================================
+ Coverage 73.10% 73.83% +0.73%
- Complexity 649 663 +14
============================================
Files 79 79
Lines 3294 3314 +20
Branches 257 263 +6
============================================
+ Hits 2408 2447 +39
+ Misses 773 752 -21
- Partials 113 115 +2 ☔ View full report in Codecov by Sentry. |
src/main/java/org/opensearch/flowframework/rest/RestGetWorkflowStepAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStepTransportAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/flowframework/transport/GetWorkflowStepTransportAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Owais Kazi <[email protected]>
d2cba50
to
3429ac3
Compare
…538) * Added optional step param to get the workflow steps API Signed-off-by: Owais Kazi <[email protected]> * Fixed api response Signed-off-by: Owais Kazi <[email protected]> * Added tests Signed-off-by: Owais Kazi <[email protected]> * Added CHANGELOG Signed-off-by: Owais Kazi <[email protected]> * Addressed PR comments Signed-off-by: Owais Kazi <[email protected]> * Added another test Signed-off-by: Owais Kazi <[email protected]> * Logged exception message Signed-off-by: Owais Kazi <[email protected]> --------- Signed-off-by: Owais Kazi <[email protected]> (cherry picked from commit 2c6dfd5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…low steps API (#542) Added an optional workflow_step param to the get workflow steps API (#538) * Added optional step param to get the workflow steps API * Fixed api response * Added tests * Added CHANGELOG * Addressed PR comments * Added another test * Logged exception message --------- (cherry picked from commit 2c6dfd5) Signed-off-by: Owais Kazi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Added an optional workflow_step param to the get workflow steps API.
Request:
Response:
Issues Resolved
Resolves #456
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.