-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSCI][DOCs] Replacing 'indices' terms for 'indexes' terms ONLY for description texts #5353
Merged
Naarcha-AWS
merged 11 commits into
opensearch-project:main
from
BigSamu:docs/indices-to-indexes
Oct 31, 2023
Merged
[OSCI][DOCs] Replacing 'indices' terms for 'indexes' terms ONLY for description texts #5353
Naarcha-AWS
merged 11 commits into
opensearch-project:main
from
BigSamu:docs/indices-to-indexes
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uery DSL Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
…s (not variables, links or properties) Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
BigSamu
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
seanneumann,
AMoo-Miki and
natebower
as code owners
October 21, 2023 15:48
4 tasks
Naarcha-AWS
reviewed
Oct 25, 2023
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
requested changes
Oct 25, 2023
Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
…documentation-website into docs/indices-to-indexes
Signed-off-by: Samuel Valdes Gutierrez <[email protected]>
@BigSamu: Once we fix the final merge conflicts, we can merge. |
Naarcha-AWS
approved these changes
Oct 31, 2023
…e/index.md Signed-off-by: Naarcha-AWS <[email protected]>
…nce/indices.md Signed-off-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
…escription texts (#5353) * Fixing documentation for Wildcard in term-level queries section for Query DSL Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * replacing 'indices' term for 'indexes' term ONLY for description texts (not variables, links or properties) Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * Update creating-custom-workloads.md Signed-off-by: Naarcha-AWS <[email protected]> * updating changes suggested by Naarcha-AWS Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * updating changes suggested by Naarcha-AWS Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * Rename _benchmark/workloads/index.md to _benchmark/workloads/reference/index.md Signed-off-by: Naarcha-AWS <[email protected]> * Rename _benchmark/workloads/indices.md to _benchmark/workloads/reference/indices.md Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Samuel Valdes Gutierrez <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]> (cherry picked from commit 7012af1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
added a commit
that referenced
this pull request
Oct 31, 2023
…escription texts (#5353) (#5456) * Fixing documentation for Wildcard in term-level queries section for Query DSL * replacing 'indices' term for 'indexes' term ONLY for description texts (not variables, links or properties) * Update creating-custom-workloads.md * updating changes suggested by Naarcha-AWS * updating changes suggested by Naarcha-AWS * Rename _benchmark/workloads/index.md to _benchmark/workloads/reference/index.md * Rename _benchmark/workloads/indices.md to _benchmark/workloads/reference/indices.md --------- (cherry picked from commit 7012af1) Signed-off-by: Samuel Valdes Gutierrez <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <[email protected]>
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
…escription texts (#5353) * Fixing documentation for Wildcard in term-level queries section for Query DSL Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * replacing 'indices' term for 'indexes' term ONLY for description texts (not variables, links or properties) Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * Update creating-custom-workloads.md Signed-off-by: Naarcha-AWS <[email protected]> * updating changes suggested by Naarcha-AWS Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * updating changes suggested by Naarcha-AWS Signed-off-by: Samuel Valdes Gutierrez <[email protected]> * Rename _benchmark/workloads/index.md to _benchmark/workloads/reference/index.md Signed-off-by: Naarcha-AWS <[email protected]> * Rename _benchmark/workloads/indices.md to _benchmark/workloads/reference/indices.md Signed-off-by: Naarcha-AWS <[email protected]> --------- Signed-off-by: Samuel Valdes Gutierrez <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]> Co-authored-by: Naarcha-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing in documentation website 'indices' terms for 'indexes' terms ONLY for description texts. For the cases where the 'indices' reference where used as variables, in links, as properties or another part in the code base, those changes where NOT executed.
Issues Resolved
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.