-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Change non-hardcoded references to "indices" to "indexes" #2358
Comments
This is the same as #1046. I'm ok with closing that one and tracking against this if you would prefer. |
Yeah, let's do that so that we're more current. |
This one has been fixed: https://opensearch.org/docs/latest/security/configuration/system-indices/, but there are still others. |
@Naarcha-AWS, can I take this issue? |
@hdhalter should be URLs also updated? In the quote you described thinking the URL should be https://opensearch.org/docs/latest/security/configuration/system-indixes/ instead of https://opensearch.org/docs/latest/security/configuration/system-indices/. Just to keep consistency. Of course, the 1st link is not already setup for getting to the expected site (Documentation System Indexes) |
Hi @BigSamu - Thanks so much for taking this on! I didn't change the URL at the time because changing the URL has a ripple effect, that is, you have to make sure you're not introducing any broken links. You also have to add a redirect in the file. Let me know if you need more info. |
Hey @hdhalter, thanks for your reply. So after looking the documentation I have the following questions if you don't mind so I can proceed:
So what I believe is the best approach as the first task is only to change the documentation where I find ONLY strings with the word @Naarcha-AWS I accept suggestions from your side too. Regards, Samuel |
I just finished opening PR #5353 for this issue. After further inspection, the change of non-harcoded variables is going to be tricky and needs a planning with the owners of each part of the source code, I think. The PR created in this case is replacing the references of 'indices' to 'indexes' ONLY in the cases of description texts. Those changes were NOT executed for the cases where the 'indices' term was used as variables, in links, as properties, or another part in the code base. I would appreciate your feedback to see how I can continue helping on this issue. Maybe it will be useful to open a set of individual issues, bringing the owners of each part of the source code to work together with the documentation team, so the update for the code and the documentation could be done in parallel at the same time. Also, I suggest to add may be a banner in the documentation website detailing that OpenSearch is in the process of changing 'indices' references to 'indexes'. That will avoid confusions I believe. Regards, Samuel |
Closing this issue for now. We can start an initiative to update the other plugins in a separate issue. |
@Naarcha-AWS count with me for that initiative. |
What do you want to do?
Tell us about your request. Provide a summary of the request and all versions that are affected.
Please change non-hardcoded references to indices to indexes.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
For example, the heading of this page should be "System indexes", and the second sentence should read "Even if your user account has read permissions for all indexes..."
The text was updated successfully, but these errors were encountered: