Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Change non-hardcoded references to "indices" to "indexes" #2358

Closed
1 of 4 tasks
natebower opened this issue Jan 9, 2023 · 10 comments
Closed
1 of 4 tasks

[DOC] Change non-hardcoded references to "indices" to "indexes" #2358

natebower opened this issue Jan 9, 2023 · 10 comments
Assignees
Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started good first issue Good for newcomers v-All This issue is valid for all versions through 1.3

Comments

@natebower
Copy link
Collaborator

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Please change non-hardcoded references to indices to indexes.

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
For example, the heading of this page should be "System indexes", and the second sentence should read "Even if your user account has read permissions for all indexes..."

@Naarcha-AWS
Copy link
Collaborator

This is the same as #1046. I'm ok with closing that one and tracking against this if you would prefer.

@natebower
Copy link
Collaborator Author

Yeah, let's do that so that we're more current.

@Naarcha-AWS Naarcha-AWS added good first issue Good for newcomers v-All This issue is valid for all versions through 1.3 and removed good first issue Good for newcomers labels Jan 9, 2023
@Naarcha-AWS Naarcha-AWS added 1 - Backlog Issue: The issue is unassigned or assigned but not started and removed untriaged labels Jan 25, 2023
@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog Issue: The issue is unassigned or assigned but not started labels Mar 22, 2023
@hdhalter
Copy link
Contributor

This one has been fixed: https://opensearch.org/docs/latest/security/configuration/system-indices/, but there are still others.

@Naarcha-AWS Naarcha-AWS added good first issue Good for newcomers 1 - Backlog Issue: The issue is unassigned or assigned but not started and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Sep 8, 2023
@BigSamu
Copy link
Contributor

BigSamu commented Oct 10, 2023

@Naarcha-AWS, can I take this issue?

@BigSamu
Copy link
Contributor

BigSamu commented Oct 10, 2023

This one has been fixed: https://opensearch.org/docs/latest/security/configuration/system-indices/, but there are still others.

@hdhalter should be URLs also updated? In the quote you described thinking the URL should be https://opensearch.org/docs/latest/security/configuration/system-indixes/ instead of https://opensearch.org/docs/latest/security/configuration/system-indices/. Just to keep consistency. Of course, the 1st link is not already setup for getting to the expected site (Documentation System Indexes)

@hdhalter
Copy link
Contributor

Hi @BigSamu - Thanks so much for taking this on! I didn't change the URL at the time because changing the URL has a ripple effect, that is, you have to make sure you're not introducing any broken links. You also have to add a redirect in the file. Let me know if you need more info.

@BigSamu
Copy link
Contributor

BigSamu commented Oct 13, 2023

Hey @hdhalter, thanks for your reply. So after looking the documentation I have the following questions if you don't mind so I can proceed:

  • What does @natebower refer to when he asks for changes in non-harcoded references? Look at references that are defined as indices or Indices and change them to indexes or Indexes, respectively. Here, the problem is that we need an update of the base code before proceeding for a change like this. Or not?
  • Following the previous point, I did a lookup in the documentation-website base code for the word indices. The results I got were the ones in this link. For tackling this issue, I see in this search results many places for doing updates. Wondering how I should proceed. I think this issue should be worked on incrementally. For instance:
  • For the search results in the about.md file (screenshot below), we can make updates now with no problems because this will not break anything. It is just updating strings in the documentation from indices or Indices to indexes or Indexes

image

  • For the search results in the _api-reference/popular-api.md and _security/configuration/system-indices.md files (screenshots below), the changes you mentioned imply changes in URLs and properties, which means the base code has to be updated, before proceeding making these changes.

image

image

So what I believe is the best approach as the first task is only to change the documentation where I find ONLY strings with the word indices or Indices and changes to indexes or Indexes. Later in the new steps, we should start updating the documentation once the base code is updated, which will mean a collaborative approach with maintainers. Make sense?

@Naarcha-AWS I accept suggestions from your side too.

Regards,

Samuel

@BigSamu
Copy link
Contributor

BigSamu commented Oct 21, 2023

@Naarcha-AWS @hdhalter,

I just finished opening PR #5353 for this issue. After further inspection, the change of non-harcoded variables is going to be tricky and needs a planning with the owners of each part of the source code, I think.

The PR created in this case is replacing the references of 'indices' to 'indexes' ONLY in the cases of description texts. Those changes were NOT executed for the cases where the 'indices' term was used as variables, in links, as properties, or another part in the code base.

I would appreciate your feedback to see how I can continue helping on this issue. Maybe it will be useful to open a set of individual issues, bringing the owners of each part of the source code to work together with the documentation team, so the update for the code and the documentation could be done in parallel at the same time.

Also, I suggest to add may be a banner in the documentation website detailing that OpenSearch is in the process of changing 'indices' references to 'indexes'. That will avoid confusions I believe.

Regards,

Samuel

@Naarcha-AWS
Copy link
Collaborator

Closing this issue for now. We can start an initiative to update the other plugins in a separate issue.

@BigSamu
Copy link
Contributor

BigSamu commented Dec 5, 2023

Closing this issue for now. We can start an initiative to update the other plugins in a separate issue.

@Naarcha-AWS count with me for that initiative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started good first issue Good for newcomers v-All This issue is valid for all versions through 1.3
Projects
None yet
Development

No branches or pull requests

4 participants