Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Wrong score formula for cosinesimil space in approximate knn and knn-score-script #4138

Closed
SeyedAlirezaFatemi opened this issue May 22, 2023 · 0 comments
Closed

[DOC] Wrong score formula for cosinesimil space in approximate knn and knn-score-script #4138

SeyedAlirezaFatemi opened this issue May 22, 2023 · 0 comments
Assignees
@SeyedAlirezaFatemi
Labels
2 - In progress Issue/PR: The issue or PR is in progress.

Comments

@SeyedAlirezaFatemi
Copy link
Contributor

SeyedAlirezaFatemi commented May 22, 2023 •
edited
Loading

The formula for the OpenSearch Score for cosinesimil space type and Lucene engine in this page is wrong.
Also, the formula for the OpenSearch Score and distance function for cosinesimil space type in this page is wrong. In this case, the cosine similarity formula is written, not the cosine distance.
SeyedAlirezaFatemi added a commit to SeyedAlirezaFatemi/documentation-website that referenced this issue May 22, 2023
@SeyedAlirezaFatemi
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (o…
cd12485 
…pensearch-project#4138)
@SeyedAlirezaFatemi SeyedAlirezaFatemi mentioned this issue May 22, 2023
Merged
1 task
@Naarcha-AWS Naarcha-AWS added 2 - In progress Issue/PR: The issue or PR is in progress. and removed untriaged labels May 22, 2023
SeyedAlirezaFatemi added a commit to SeyedAlirezaFatemi/documentation-website that referenced this issue May 25, 2023
@SeyedAlirezaFatemi
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (o…
1acee03 
…pensearch-project#4138)

Signed-off-by: Alireza Fatemi <[email protected]>
kolchfa-aws pushed a commit that referenced this issue May 25, 2023
@SeyedAlirezaFatemi
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
8d394f5 
…4138) (#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 25, 2023
@github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
8b57529 
…4138) (#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
(cherry picked from commit 8d394f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 25, 2023
@github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
9da56a7 
…4138) (#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
(cherry picked from commit 8d394f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 25, 2023
@github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
23c3e70 
…4138) (#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
(cherry picked from commit 8d394f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 25, 2023
@github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
f5ade99 
…4138) (#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
(cherry picked from commit 8d394f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 25, 2023
@github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
cce4978 
…4138) (#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
(cherry picked from commit 8d394f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue May 25, 2023
@github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
5e43c48 
…4138) (#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
(cherry picked from commit 8d394f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this issue May 25, 2023
@opensearch-trigger-bot @github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
f201b07 
…4138) (#4139) (#4180)

(cherry picked from commit 8d394f5)

Signed-off-by: Alireza Fatemi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this issue May 25, 2023
@opensearch-trigger-bot @github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
bc44a5a 
…4138) (#4139) (#4179)

(cherry picked from commit 8d394f5)

Signed-off-by: Alireza Fatemi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this issue May 25, 2023
@opensearch-trigger-bot @github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
f3660cd 
…4138) (#4139) (#4178)

(cherry picked from commit 8d394f5)

Signed-off-by: Alireza Fatemi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this issue May 25, 2023
@opensearch-trigger-bot @github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
7949f53 
…4138) (#4139) (#4177)

(cherry picked from commit 8d394f5)

Signed-off-by: Alireza Fatemi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this issue May 25, 2023
@opensearch-trigger-bot @github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
7a84065 
…4138) (#4139) (#4176)

(cherry picked from commit 8d394f5)

Signed-off-by: Alireza Fatemi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kolchfa-aws pushed a commit that referenced this issue May 25, 2023
@opensearch-trigger-bot @github-actions
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
441e9f8 
…4138) (#4139) (#4175)

(cherry picked from commit 8d394f5)

Signed-off-by: Alireza Fatemi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit that referenced this issue May 26, 2023
@SeyedAlirezaFatemi @vagimeli
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (#…
017761c 
…4138) (#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
harshavamsi pushed a commit to harshavamsi/documentation-website that referenced this issue Oct 31, 2023
@SeyedAlirezaFatemi @harshavamsi
[Doc] Fix cosinesimil OpenSearch Score and Distance Function formula (o…
2ee5edc 
…pensearch-project#4138) (opensearch-project#4139)

Signed-off-by: Alireza Fatemi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeyedAlirezaFatemi SeyedAlirezaFatemi

Labels
2 - In progress Issue/PR: The issue or PR is in progress.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SeyedAlirezaFatemi @Naarcha-AWS