Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set the GitHub Actions thumbprint in the release CDK stack #2345

Merged

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Mar 1, 2023

Description

Use the GitHub thumbprint as specified here: https://github.blog/changelog/2022-01-13-github-actions-update-on-oidc-based-deployments-to-aws/

Also updated the AWS CDK to the latest version.

Issues Resolved

Resolves #2343

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dlvenable dlvenable requested a review from a team as a code owner March 1, 2023 19:22
@codecov-commenter
Copy link

Codecov Report

Merging #2345 (6f84f08) into main (062ae95) will increase coverage by 0.05%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #2345      +/-   ##
============================================
+ Coverage     93.81%   93.87%   +0.05%     
- Complexity     1978     1979       +1     
============================================
  Files           229      229              
  Lines          5501     5501              
  Branches        443      443              
============================================
+ Hits           5161     5164       +3     
+ Misses          230      228       -2     
+ Partials        110      109       -1     
Impacted Files Coverage Δ
...opensearch/dataprepper/pipeline/ProcessWorker.java 90.38% <0.00%> (+1.92%) ⬆️
...rwarder/discovery/AwsCloudMapPeerListProvider.java 95.23% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlvenable dlvenable merged commit 46d08cb into opensearch-project:main Mar 1, 2023
@dlvenable dlvenable deleted the 2343-github-thumbprint branch March 1, 2023 22:53
mahesh724 pushed a commit to mahesh724/data-prepper that referenced this pull request Mar 3, 2023
mahesh724 pushed a commit to mahesh724/data-prepper that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Data Prepper release builds failing
4 participants