Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Build] export config file #183

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 18, 2023

Description

In the release build the config file wasn't being exported therefore when compiled down OpenSearch Dashboards wouldn't start.

To see error:

wget https://ci.opensearch.org/ci/dbc/distribution-build-opensearch-dashboards/3.0.0/latest/linux/x64/tar/dist/opensearch-dashboards/opensearch-dashboards-3.0.0-linux-x64.tar.gz

tar -xzf opensearch-dashboards-3.0.0-linux-x64.tar.gz

./opensearch-dashboards-3.0.0/bin/opensearch-dashboards

Issues Resolved

n/a

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #183 (c8f8535) into main (031a761) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          15       15           
  Lines         204      204           
  Branches       40       40           
=======================================
  Hits          176      176           
  Misses         26       26           
  Partials        2        2           
Flag Coverage Δ
dashboards-search-relevance 86.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

In the release build the config file wasn't being exported therefore
when compiled down OpenSearch Dashboards wouldn't start.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla force-pushed the avillk/add_config branch from c8f8535 to 2b84824 Compare April 18, 2023 22:38
@noCharger
Copy link
Collaborator

Thanks @kavilla for the bugfix. Create an issue to improve the github workflow so that it can test builds from zip files #184

@noCharger noCharger merged commit 7c6ce17 into opensearch-project:main Apr 18, 2023
github-actions bot pushed a commit that referenced this pull request Apr 18, 2023
In the release build the config file wasn't being exported therefore
when compiled down OpenSearch Dashboards wouldn't start.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 7c6ce17)
Signed-off-by: Kawika Avilla <[email protected]>
github-actions bot pushed a commit that referenced this pull request Apr 18, 2023
In the release build the config file wasn't being exported therefore
when compiled down OpenSearch Dashboards wouldn't start.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 7c6ce17)
Signed-off-by: Kawika Avilla <[email protected]>
noCharger pushed a commit that referenced this pull request Apr 18, 2023
In the release build the config file wasn't being exported therefore
when compiled down OpenSearch Dashboards wouldn't start.

Issue:
n/a


(cherry picked from commit 7c6ce17)

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
noCharger pushed a commit that referenced this pull request Apr 18, 2023
In the release build the config file wasn't being exported therefore
when compiled down OpenSearch Dashboards wouldn't start.

Issue:
n/a


(cherry picked from commit 7c6ce17)

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants