Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test builds from zip files #184

Open
noCharger opened this issue Apr 18, 2023 · 3 comments
Open

[CI] Test builds from zip files #184

noCharger opened this issue Apr 18, 2023 · 3 comments
Labels
CI continuous integration enhancement

Comments

@noCharger
Copy link
Collaborator

noCharger commented Apr 18, 2023

Description

Although config.ts is added at the top level of the plugin, it is not included in the construction artifact when using the command yarn plugin-helpers build. The current github testing workflows always get the source code through checkout. (see examples https://github.com/opensearch-project/dashboards-search-relevance/blob/main/.github/workflows/remote-integ-tests-workflow.yml#L72-L75 and https://github.com/opensearch-project/dashboards-search-relevance/blob/main/.github/workflows/test-and-build.yml#L22-L25). We should instead utilize build artifacts for integration testing.

@noCharger noCharger moved this from 🆕 New to Now(This Quarter) in Search Project Board Apr 18, 2023
@noCharger noCharger added CI continuous integration enhancement and removed untriaged labels Apr 18, 2023
@noCharger noCharger changed the title Test builds from zip files. [CI] Test builds from zip files Apr 18, 2023
@dblock
Copy link
Member

dblock commented Apr 21, 2023

Is this a problem for all plugins? Could we please open a meta issue in OpenSearch-Dashboards and do this for all plugins? cc: @kavilla

@kavilla
Copy link
Member

kavilla commented Apr 21, 2023

Is this a problem for all plugins? Could we please open a meta issue in OpenSearch-Dashboards and do this for all plugins? cc: @kavilla

Opened this:
opensearch-project/OpenSearch-Dashboards#3918

@sejli
Copy link
Member

sejli commented Jun 13, 2023

Current progress is being worked on and monitored here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration enhancement
Projects
Status: Now(This Quarter)
Development

No branches or pull requests

4 participants