Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add flyout pages to associated objects table #1507

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

RyanL1997
Copy link
Collaborator

Description

Manual backport of #1496: Add flyout pages to associated objects table.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 added the enhancement New feature or request label Mar 9, 2024
@RyanL1997 RyanL1997 marked this pull request as ready for review March 9, 2024 01:59
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 78.18182% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 56.87%. Comparing base (b4c04d8) to head (0861073).

Files Patch % Lines
...nage/associated_objects/associated_objects_tab.tsx 55.55% 8 Missing ⚠️
...ted_objects/utils/associated_objects_tab_utils.tsx 66.66% 3 Missing ⚠️
...ated_objects/associated_objects_details_flyout.tsx 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1507      +/-   ##
==========================================
+ Coverage   54.73%   56.87%   +2.14%     
==========================================
  Files         345      329      -16     
  Lines       12347    11942     -405     
  Branches     3171     3082      -89     
==========================================
+ Hits         6758     6792      +34     
+ Misses       5533     5096     -437     
+ Partials       56       54       -2     
Flag Coverage Δ
dashboards-observability 56.87% <78.18%> (+2.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…oject#1496)

* Add acceleration flyout to associated objects table

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton 1

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton 2

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout for acceleration table

Signed-off-by: Ryan Liang <[email protected]>

* Add no acceleration items page for acc table in flyout

Signed-off-by: Ryan Liang <[email protected]>

* Add the table column table in the detail flyout

Signed-off-by: Ryan Liang <[email protected]>

* Add check for table content type

Signed-off-by: Ryan Liang <[email protected]>

* Add jest test for assc obj flyout

Signed-off-by: Ryan Liang <[email protected]>

* Remove the console log for mock

Signed-off-by: Ryan Liang <[email protected]>

* Set up acceleration status type

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
@RyanL1997 RyanL1997 force-pushed the backport-associated-obj-2x branch from fb63d3a to 0861073 Compare March 9, 2024 19:20
@ps48 ps48 merged commit 524e501 into opensearch-project:2.x Mar 9, 2024
15 of 19 checks passed
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…oject#1496) (opensearch-project#1507)

* Add acceleration flyout to associated objects table

* Add assc obj table details flyout skeleton

* Add assc obj table details flyout skeleton 1

* Add assc obj table details flyout skeleton 2

* Add assc obj table details flyout for acceleration table

* Add no acceleration items page for acc table in flyout

* Add the table column table in the detail flyout

* Add check for table content type

* Add jest test for assc obj flyout

* Remove the console log for mock

* Set up acceleration status type

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 524e501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants