-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add flyout pages to associated objects table #1496
[Feature] Add flyout pages to associated objects table #1496
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
+ Coverage 54.39% 56.58% +2.18%
==========================================
Files 347 331 -16
Lines 12563 12138 -425
Branches 3213 3119 -94
==========================================
+ Hits 6834 6868 +34
+ Misses 5673 5216 -457
+ Partials 56 54 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ecbdf7f
to
d0b6834
Compare
public/components/datasources/components/__tests__/data_connection.test.tsx
Show resolved
Hide resolved
1712952
to
b5d8ecf
Compare
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
7a23224
to
e17a3d2
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1496-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df7020a2eab70646f3ceacb15d45e2d4b8f94336
# Push it to GitHub
git push --set-upstream origin backport/backport-1496-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
…oject#1496) * Add acceleration flyout to associated objects table Signed-off-by: Ryan Liang <[email protected]> * Add assc obj table details flyout skeleton Signed-off-by: Ryan Liang <[email protected]> * Add assc obj table details flyout skeleton 1 Signed-off-by: Ryan Liang <[email protected]> * Add assc obj table details flyout skeleton 2 Signed-off-by: Ryan Liang <[email protected]> * Add assc obj table details flyout for acceleration table Signed-off-by: Ryan Liang <[email protected]> * Add no acceleration items page for acc table in flyout Signed-off-by: Ryan Liang <[email protected]> * Add the table column table in the detail flyout Signed-off-by: Ryan Liang <[email protected]> * Add check for table content type Signed-off-by: Ryan Liang <[email protected]> * Add jest test for assc obj flyout Signed-off-by: Ryan Liang <[email protected]> * Remove the console log for mock Signed-off-by: Ryan Liang <[email protected]> * Set up acceleration status type Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
…oject#1496) * Add acceleration flyout to associated objects table Signed-off-by: Ryan Liang <[email protected]> * Add assc obj table details flyout skeleton Signed-off-by: Ryan Liang <[email protected]> * Add assc obj table details flyout skeleton 1 Signed-off-by: Ryan Liang <[email protected]> * Add assc obj table details flyout skeleton 2 Signed-off-by: Ryan Liang <[email protected]> * Add assc obj table details flyout for acceleration table Signed-off-by: Ryan Liang <[email protected]> * Add no acceleration items page for acc table in flyout Signed-off-by: Ryan Liang <[email protected]> * Add the table column table in the detail flyout Signed-off-by: Ryan Liang <[email protected]> * Add check for table content type Signed-off-by: Ryan Liang <[email protected]> * Add jest test for assc obj flyout Signed-off-by: Ryan Liang <[email protected]> * Remove the console log for mock Signed-off-by: Ryan Liang <[email protected]> * Set up acceleration status type Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
* Add acceleration flyout to associated objects table * Add assc obj table details flyout skeleton * Add assc obj table details flyout skeleton 1 * Add assc obj table details flyout skeleton 2 * Add assc obj table details flyout for acceleration table * Add no acceleration items page for acc table in flyout * Add the table column table in the detail flyout * Add check for table content type * Add jest test for assc obj flyout * Remove the console log for mock * Set up acceleration status type --------- Signed-off-by: Ryan Liang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maintain consistency across the codebase, I think we can do some refactoring done on this file. We can move the strings to dashboards-observability/common/constants/datas_sources.ts
and the testing objects to dashboards-observability/test/datasources.ts
. We can also change this to a .ts
file since it's not exporting or returning any UI components. If in agreement, I can add these changes to my next PR.
…oject#1496) (opensearch-project#1507) * Add acceleration flyout to associated objects table * Add assc obj table details flyout skeleton * Add assc obj table details flyout skeleton 1 * Add assc obj table details flyout skeleton 2 * Add assc obj table details flyout for acceleration table * Add no acceleration items page for acc table in flyout * Add the table column table in the detail flyout * Add check for table content type * Add jest test for assc obj flyout * Remove the console log for mock * Set up acceleration status type --------- Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 524e501)
Description
This PR is adding 2 flyout pages to the associated objects table elements:
Demo
Screen.Recording.2024-03-07.at.2.32.40.PM.mov
For table with no accelerations:
Test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.