Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add flyout pages to associated objects table #1496

Merged
merged 11 commits into from
Mar 9, 2024

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Mar 6, 2024

Description

This PR is adding 2 flyout pages to the associated objects table elements:

  • table details flyout page
  • acceleration detail flyout page
  • if the item is a table, we open up the table detail flyout, if the item is a CI/SI we open up the acceleration flyout.

Demo

Screen.Recording.2024-03-07.at.2.32.40.PM.mov

For table with no accelerations:
Screenshot 2024-03-07 at 3 17 09 PM

Test

  • i18n Support
  • Jest test
  • Updated Snapshot

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 added the enhancement New feature or request label Mar 6, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 78.18182% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 56.58%. Comparing base (943126f) to head (e17a3d2).

Files Patch % Lines
...nage/associated_objects/associated_objects_tab.tsx 55.55% 8 Missing ⚠️
...ted_objects/utils/associated_objects_tab_utils.tsx 66.66% 3 Missing ⚠️
...ated_objects/associated_objects_details_flyout.tsx 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
+ Coverage   54.39%   56.58%   +2.18%     
==========================================
  Files         347      331      -16     
  Lines       12563    12138     -425     
  Branches     3213     3119      -94     
==========================================
+ Hits         6834     6868      +34     
+ Misses       5673     5216     -457     
+ Partials       56       54       -2     
Flag Coverage Δ
dashboards-observability 56.58% <78.18%> (+2.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997 RyanL1997 force-pushed the associated-obj-flyouts-m branch from ecbdf7f to d0b6834 Compare March 7, 2024 19:12
@RyanL1997 RyanL1997 marked this pull request as ready for review March 8, 2024 00:05
@RyanL1997 RyanL1997 changed the title [WIP] Add flyout pages to associated objects table [Feature] Add flyout pages to associated objects table Mar 8, 2024
@RyanL1997 RyanL1997 force-pushed the associated-obj-flyouts-m branch from 1712952 to b5d8ecf Compare March 8, 2024 22:46
@RyanL1997 RyanL1997 force-pushed the associated-obj-flyouts-m branch from 7a23224 to e17a3d2 Compare March 8, 2024 23:09
@paulstn paulstn merged commit df7020a into opensearch-project:main Mar 9, 2024
15 of 20 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1496-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 df7020a2eab70646f3ceacb15d45e2d4b8f94336
# Push it to GitHub
git push --set-upstream origin backport/backport-1496-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1496-to-2.x.

RyanL1997 added a commit to RyanL1997/dashboards-observability that referenced this pull request Mar 9, 2024
…oject#1496)

* Add acceleration flyout to associated objects table

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton 1

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton 2

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout for acceleration table

Signed-off-by: Ryan Liang <[email protected]>

* Add no acceleration items page for acc table in flyout

Signed-off-by: Ryan Liang <[email protected]>

* Add the table column table in the detail flyout

Signed-off-by: Ryan Liang <[email protected]>

* Add check for table content type

Signed-off-by: Ryan Liang <[email protected]>

* Add jest test for assc obj flyout

Signed-off-by: Ryan Liang <[email protected]>

* Remove the console log for mock

Signed-off-by: Ryan Liang <[email protected]>

* Set up acceleration status type

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
RyanL1997 added a commit to RyanL1997/dashboards-observability that referenced this pull request Mar 9, 2024
…oject#1496)

* Add acceleration flyout to associated objects table

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton 1

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout skeleton 2

Signed-off-by: Ryan Liang <[email protected]>

* Add assc obj table details flyout for acceleration table

Signed-off-by: Ryan Liang <[email protected]>

* Add no acceleration items page for acc table in flyout

Signed-off-by: Ryan Liang <[email protected]>

* Add the table column table in the detail flyout

Signed-off-by: Ryan Liang <[email protected]>

* Add check for table content type

Signed-off-by: Ryan Liang <[email protected]>

* Add jest test for assc obj flyout

Signed-off-by: Ryan Liang <[email protected]>

* Remove the console log for mock

Signed-off-by: Ryan Liang <[email protected]>

* Set up acceleration status type

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
ps48 pushed a commit that referenced this pull request Mar 9, 2024
* Add acceleration flyout to associated objects table



* Add assc obj table details flyout skeleton



* Add assc obj table details flyout skeleton 1



* Add assc obj table details flyout skeleton 2



* Add assc obj table details flyout for acceleration table



* Add no acceleration items page for acc table in flyout



* Add the table column table in the detail flyout



* Add check for table content type



* Add jest test for assc obj flyout



* Remove the console log for mock



* Set up acceleration status type



---------

Signed-off-by: Ryan Liang <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain consistency across the codebase, I think we can do some refactoring done on this file. We can move the strings to dashboards-observability/common/constants/datas_sources.ts and the testing objects to dashboards-observability/test/datasources.ts. We can also change this to a .ts file since it's not exporting or returning any UI components. If in agreement, I can add these changes to my next PR.

amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…oject#1496) (opensearch-project#1507)

* Add acceleration flyout to associated objects table

* Add assc obj table details flyout skeleton

* Add assc obj table details flyout skeleton 1

* Add assc obj table details flyout skeleton 2

* Add assc obj table details flyout for acceleration table

* Add no acceleration items page for acc table in flyout

* Add the table column table in the detail flyout

* Add check for table content type

* Add jest test for assc obj flyout

* Remove the console log for mock

* Set up acceleration status type

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 524e501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants