Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshots for upstream typescript bump #1300

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Dec 14, 2023

Description

Recently there as typescript and axios bump in OepnSearch-Dashboards. Upstream change caused dashboards-observability snapshots to fail.

OpenSearch-Dashboards PR: opensearch-project/OpenSearch-Dashboards#5470

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48
Copy link
Member Author

ps48 commented Dec 14, 2023

The typescript bump is not backported to 2.x so no need to backport this PR.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f091bd) 56.32% compared to head (840d11d) 56.32%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1300    +/-   ##
========================================
  Coverage   56.32%   56.32%            
========================================
  Files         327      327            
  Lines       11944    11944            
  Branches     2800     2741    -59     
========================================
  Hits         6728     6728            
- Misses       4913     5171   +258     
+ Partials      303       45   -258     
Flag Coverage Δ
dashboards-observability 56.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavithacm kavithacm merged commit c775d85 into opensearch-project:main Dec 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants