-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump typescript and axios #5470
Conversation
ebf5753
to
93e4fb2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5470 +/- ##
==========================================
- Coverage 66.98% 66.97% -0.02%
==========================================
Files 3293 3293
Lines 63287 63289 +2
Branches 10062 10065 +3
==========================================
- Hits 42394 42388 -6
- Misses 18453 18459 +6
- Partials 2440 2442 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c561e72
to
1314515
Compare
* Bump axios due to CVE-2023-45857 * Bump typescript, only in resolutions, to 4.6.4 - needed for newer axios Signed-off-by: Miki <[email protected]>
1314515
to
327d053
Compare
Signed-off-by: Miki <[email protected]>
@AMoo-Miki @ananzh @joshuarrrr Is there a reason why this PR wasn't backported to 2.x. For dashboards-observability we suspect that this upstream change is causing our snapshots to fail. Updating the snapshots solely for main will lead to divergence between main and 2.x. This will break our 2.x backports for test updates. Meanwhile @pjfitzgibbons is verifying that this upstream PR was the root-cause for snapshot failures. |
@ps48 bumping
|
Description
Bump typescript and axios
Fixes #5474
Check List
yarn test:jest
yarn test:jest_integration