Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Cypress fix] Wait map saved before open maps listing #221

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport bb947ed from #218

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team January 26, 2023 04:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Merging #221 (bb947ed) into 2.x (1249653) will not change coverage.
The diff coverage is n/a.

❗ Current head bb947ed differs from pull request most recent head 8059ac9. Consider uploading reports for the commit 8059ac9 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x     #221   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files           6        6           
  Lines         176      176           
  Branches       24       24           
=======================================
  Hits          154      154           
  Misses         16       16           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@junqiu-lei
Copy link
Member

Currently this 2.x branch consuming OSD 2.5 branch, which changed the version number to 2.5.1, I think that might be the reason that Cypress test failed. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.5/package.json#L14

@VijayanB
Copy link
Member

VijayanB commented Feb 1, 2023

Currently this 2.x branch consuming OSD 2.5 branch, which changed the version number to 2.5.1, I think that might be the reason that Cypress test failed. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.5/package.json#L14

Given this is 2.x branch, shouldn't this be point to 2.6?

@junqiu-lei
Copy link
Member

Closing the PR since this code change got merged with #232

@junqiu-lei junqiu-lei closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants