[Cypress fix] Wait map saved before open maps listing #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
changed the title
Codecov Report
@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 6 6
Lines 175 175
Branches 24 24
=======================================
Hits 153 153
Misses 16 16
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
junqiu-lei
force-pushed
the
cypress_windows
branch
from
25e907d to
cd63d80
Compare
junqiu-lei
changed the title
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
force-pushed
the
cypress_windows
branch
from
cd63d80 to
3239ab8
Compare
|
This fix code also passed test in another PR: https://github.com/junqiu-lei/dashboards-maps/actions/runs/3970639890/jobs/6806596016 |
navneet1v
requested review from
VijayanB,
naveentatikonda and
martin-gaievski
martin-gaievski
approved these changes
Jan 26, 2023
VijayanB
approved these changes
Jan 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit bb947ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei [email protected]
Description
Wait map saved before redirect to maps listing page, so that void not able to find saved map in listing page. This issue only happens in GH action cypress CI window OS.
Issues Resolved
#210
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.