Integration test for cluster reroute in #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soosinha
reviewed
Aug 4, 2021
| @@ -334,6 +335,87 @@ abstract class MultiClusterRestTestCase : ESTestCase() { | |||
| assertEquals(HttpStatus.SC_OK.toLong(), persistentConnectionResponse.statusLine.statusCode.toLong()) | |||
| } | |||
|
|
|||
| protected fun getPrimaryNodeForShard(clusterName: String,indexname: String, shardNumber: String) :String { | |||
| val cluster = getNamedCluster(clusterName) | |||
| val persistentConnectionRequest = Request("GET", "/_cat/shards") | |||
There was a problem hiding this comment.
You can call _cat/shards?format=json to make it easier to parse the response.
soosinha
reviewed
Aug 4, 2021
|
|
||
| protected fun getNodesInCluster(clusterName: String) : List<String>{ | ||
| val cluster = getNamedCluster(clusterName) | ||
| val persistentConnectionRequest = Request("GET", "/_cat/nodes") |
There was a problem hiding this comment.
Same suggestion as above to use _cat/nodes?format=json
| persistentConnectionRequest.entity = NStringEntity(entityAsString, ContentType.APPLICATION_JSON) | ||
| cluster.lowLevelClient.performRequest(persistentConnectionRequest) | ||
| } | ||
| } |
There was a problem hiding this comment.
minor: new lines at the end of new files
Comment on lines
+40
to
+42
| assertBusy ({ | ||
| Assertions.assertThat(followerClient.indices().exists(GetIndexRequest(followerIndexName), RequestOptions.DEFAULT)).isEqualTo(true) | ||
| }, 1, TimeUnit.MINUTES) |
There was a problem hiding this comment.
I dont think you need to wait here to ensure that follower index exists. You can proceed to add data to leader.
krishna-ggk
reviewed
Aug 5, 2021
Comment on lines
+66
to
+73
| //TODO: Fix this and uncomment this code | ||
| /*assertBusy ({ | ||
| try { | ||
| Assertions.assertThat(docs(FOLLOWER, followerIndexName)).contains("dummy data 2") | ||
| } catch (ex: Exception) { | ||
| Assertions.assertThat(true).isEqualTo(false) | ||
| } | ||
| }, 1, TimeUnit.MINUTES)*/ |
There was a problem hiding this comment.
What is the current issue here?
There was a problem hiding this comment.
this is solved in the pr #114
1 task
krishna-ggk
requested changes
Sep 1, 2021
|
This is already addressed in #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration test for cluster reroute case
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.