Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting missing shard tasks #114

Merged

Conversation

tbhanu-amzn
Copy link
Contributor

Description

Start missing failed tasks

Issues Resolved

start missing failed tasks

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@krishna-ggk krishna-ggk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

Can we also add tests?

@saikaranam-amazon
Copy link
Member

Integration tests are tracked here: #81
Once the ES Changes and IT are pushed to ES_7.10 branch. We will port to main branch

ankitkala
ankitkala previously approved these changes Aug 24, 2021
Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ankitkala
ankitkala previously approved these changes Aug 26, 2021
Added additional logging to the APIs

Signed-off-by: Sai Kumar <[email protected]>
Copy link
Contributor

@naveenpajjuri naveenpajjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikaranam-amazon saikaranam-amazon merged commit 7598c12 into opensearch-project:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants