Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to use document replication for system indices. #802

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Add setting to use document replication for system indices. #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/kotlin/org/opensearch/replication/metadata/store/ReplicationMetadataStore.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import org.opensearch.common.xcontent.LoggingDeprecationHandler
import org.opensearch.core.xcontent.NamedXContentRegistry
import org.opensearch.core.xcontent.ToXContent
import org.opensearch.core.xcontent.XContentParser
import org.opensearch.indices.replication.common.ReplicationType
import org.opensearch.replication.util.suspendExecuteWithRetries

class ReplicationMetadataStore constructor(val client: Client, val clusterService: ClusterService,
Expand Down Expand Up @@ -265,6 +266,7 @@ class ReplicationMetadataStore constructor(val client: Client, val clusterServic
.put(IndexMetadata.INDEX_AUTO_EXPAND_REPLICAS_SETTING.key, "0-1")
.put(IndexMetadata.INDEX_PRIORITY_SETTING.key, Int.MAX_VALUE)
.put(IndexMetadata.INDEX_HIDDEN_SETTING.key, true)
.put(IndexMetadata.INDEX_REPLICATION_TYPE_SETTING.key, ReplicationType.DOCUMENT) // System Indices should use Document Replication strategy
Copy link
Member

@ankitkala ankitkala Apr 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that INDEX_REPLICATION_TYPE_SETTING is not behind feature flag for Segment Replication?

Just trying to ensure that this setting is available always.

Copy link
Member Author

@Rishikesh1159 Rishikesh1159 Apr 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes INDEX_REPLICATION_TYPE_SETTING is not behind feature flag anymore. We have removed the feature flag in PR: opensearch-project/OpenSearch#7045, you can see this here it is directly added as built in index setting and not gated by any feature flag.

.build()
}

Expand Down