Add setting to use document replication for system indices. #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishikesh1159 <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #802 +/- ##
============================================
- Coverage 73.37% 72.88% -0.49%
+ Complexity 1006 1003 -3
============================================
Files 141 141
Lines 4650 4651 +1
Branches 521 521
============================================
- Hits 3412 3390 -22
- Misses 910 933 +23
Partials 328 328
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ankitkala
reviewed
Apr 18, 2023
| @@ -265,6 +266,7 @@ class ReplicationMetadataStore constructor(val client: Client, val clusterServic | |||
| .put(IndexMetadata.INDEX_AUTO_EXPAND_REPLICAS_SETTING.key, "0-1") | |||
| .put(IndexMetadata.INDEX_PRIORITY_SETTING.key, Int.MAX_VALUE) | |||
| .put(IndexMetadata.INDEX_HIDDEN_SETTING.key, true) | |||
| .put(IndexMetadata.INDEX_REPLICATION_TYPE_SETTING.key, ReplicationType.DOCUMENT) // System Indices should use Document Replication strategy | |||
There was a problem hiding this comment.
Can you confirm that INDEX_REPLICATION_TYPE_SETTING is not behind feature flag for Segment Replication?
Just trying to ensure that this setting is available always.
There was a problem hiding this comment.
Yes INDEX_REPLICATION_TYPE_SETTING is not behind feature flag anymore. We have removed the feature flag in PR: opensearch-project/OpenSearch#7045, you can see this here it is directly added as built in index setting and not gated by any feature flag.
ankitkala
approved these changes
Apr 18, 2023
soosinha
approved these changes
Apr 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 55b6968)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 55b6968)
ankitkala
pushed a commit
that referenced
this pull request
Apr 18, 2023
) Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 55b6968) Co-authored-by: Rishikesh Pasham <[email protected]>
ankitkala
pushed a commit
that referenced
this pull request
Apr 18, 2023
) Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 55b6968) Co-authored-by: Rishikesh Pasham <[email protected]>
saikaranam-amazon
pushed a commit
to saikaranam-amazon/cross-cluster-replication-2
that referenced
this pull request
May 31, 2023
…ch-project#802) (opensearch-project#803) Signed-off-by: Rishikesh1159 <[email protected]> (cherry picked from commit 55b6968) Co-authored-by: Rishikesh Pasham <[email protected]>
monusingh-1
added a commit
to monusingh-1/ccr-dev
that referenced
this pull request
Aug 22, 2023
5 tasks
monusingh-1
added a commit
to monusingh-1/ccr-dev
that referenced
this pull request
Aug 22, 2023
…pensearch-project#802)" This reverts commit 55b6968. Signed-off-by: monusingh-1 <[email protected]>
monusingh-1
added a commit
that referenced
this pull request
Aug 22, 2023
…802)" (#1107) This reverts commit 55b6968. Signed-off-by: monusingh-1 <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
…802)" (#1107) This reverts commit 55b6968. Signed-off-by: monusingh-1 <[email protected]> (cherry picked from commit 9750b78)
monusingh-1
added a commit
that referenced
this pull request
Aug 22, 2023
…802)" (#1107) (#1108) This reverts commit 55b6968. Signed-off-by: monusingh-1 <[email protected]> (cherry picked from commit 9750b78) Co-authored-by: Monu Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds settings for system indices to use document replication strategy.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.