-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring update of final type settings in updateSettings function #1304
Conversation
Signed-off-by: Nishant Goel <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.11 #1304 +/- ##
============================================
+ Coverage 76.68% 76.81% +0.12%
- Complexity 1046 1050 +4
============================================
Files 141 141
Lines 4778 4778
Branches 525 525
============================================
+ Hits 3664 3670 +6
+ Misses 765 761 -4
+ Partials 349 347 -2 ☔ View full report in Codecov by Sentry. |
src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-1304-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e509da4dcced4842c556d7166ebc778af697c6cb
# Push it to GitHub
git push --set-upstream origin backport/backport-1304-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11 Then, create a pull request where the |
) Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit e509da4)
) (#1306) Signed-off-by: Nishant Goel <[email protected]> (cherry picked from commit e509da4) Co-authored-by: Nishant Goel <[email protected]>
…ensearch-project#1304) Signed-off-by: Nishant Goel <[email protected]>
) (#1307) Signed-off-by: Nishant Goel <[email protected]>
Description
Ignoring all the final settings to copy from leader to follower as those settings won't be able to apply as those are not updatable.
Issues Resolved
[(https://github.com//issues/1300)]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.