Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring update of final type settings in updateSettings function #1304

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

nisgoel-amazon
Copy link
Contributor

@nisgoel-amazon nisgoel-amazon commented Jan 1, 2024

Description

Ignoring all the final settings to copy from leader to follower as those settings won't be able to apply as those are not updatable.

Issues Resolved

[(https://github.com//issues/1300)]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (494c26f) 76.68% compared to head (4696d6f) 76.81%.

Files Patch % Lines
...rch/replication/task/index/IndexReplicationTask.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.11    #1304      +/-   ##
============================================
+ Coverage     76.68%   76.81%   +0.12%     
- Complexity     1046     1050       +4     
============================================
  Files           141      141              
  Lines          4778     4778              
  Branches        525      525              
============================================
+ Hits           3664     3670       +6     
+ Misses          765      761       -4     
+ Partials        349      347       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@monusingh-1 monusingh-1 merged commit e509da4 into opensearch-project:2.11 Jan 2, 2024
15 of 16 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-1304-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e509da4dcced4842c556d7166ebc778af697c6cb
# Push it to GitHub
git push --set-upstream origin backport/backport-1304-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11

Then, create a pull request where the base branch is 2.11 and the compare/head branch is backport/backport-1304-to-2.11.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 2, 2024
@nisgoel-amazon nisgoel-amazon deleted the 2.11 branch January 2, 2024 15:29
monusingh-1 pushed a commit that referenced this pull request Jan 2, 2024
) (#1306)

Signed-off-by: Nishant Goel <[email protected]>
(cherry picked from commit e509da4)

Co-authored-by: Nishant Goel <[email protected]>
nisgoel-amazon added a commit to nisgoel-amazon/cross-cluster-replication that referenced this pull request Jan 3, 2024
monusingh-1 pushed a commit that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants