Ignoring update of final type settings in updateSettings function (#1304

) Signed-off-by: Nishant Goel <[email protected]>
opensearch-project · Jan 2, 2024 · e509da4 · e509da4
1 parent 494c26f
commit e509da4
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt b/src/main/kotlin/org/opensearch/replication/task/index/IndexReplicationTask.kt
@@ -461,7 +461,7 @@ open class IndexReplicationTask(id: Long, type: String, action: String, descript
                             continue
                         }
                         val setting = indexScopedSettings[key]
-                        if (!setting.isPrivateIndex) {
+                        if (!setting.isPrivateIndex && !setting.isFinal) {
                             desiredSettingsBuilder.copy(key, settings);
                         }
                     }
@@ -473,7 +473,7 @@ open class IndexReplicationTask(id: Long, type: String, action: String, descript
                     if (desiredSettings.get(key) != followerSettings.get(key)) {
                         //Not intended setting on follower side.
                         val setting = indexScopedSettings[key]
-                        if (indexScopedSettings.isPrivateSetting(key)) {
+                        if (indexScopedSettings.isPrivateSetting(key) || setting.isFinal) {
                             continue
                         }
                         if (!setting.isDynamic()) {
@@ -486,7 +486,7 @@ open class IndexReplicationTask(id: Long, type: String, action: String, descript
 
                 for (key in followerSettings.keySet()) {
                     val setting = indexScopedSettings[key]
-                    if (setting == null || setting.isPrivateIndex) {
+                    if (setting == null || setting.isPrivateIndex || setting.isFinal) {
                         continue
                     }