[backport to 2.x] Enforce DOCUMENT Replication for AD Indices #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR, we temporarily enforce DOCUMENT replication for AD indices. This change is necessary due to the current limitation of SegRep, which doesn't support Get/MultiGet by ID. This measure will be in place until SegRep adds support for these operations. This adjustment aligns with the modification made in the referenced PR: opensearch-project/job-scheduler#417 Signed-off-by: Kaituo Li <[email protected]>
amitgalitz
approved these changes
Jul 11, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #949 +/- ##
============================================
- Coverage 79.52% 79.37% -0.16%
+ Complexity 4330 4318 -12
============================================
Files 307 307
Lines 18143 18150 +7
Branches 1909 1909
============================================
- Hits 14429 14406 -23
- Misses 2799 2826 +27
- Partials 915 918 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sudiptoguha
approved these changes
Jul 11, 2023
This was referenced Sep 1, 2023
jackiehanyang
added a commit
that referenced
this pull request
Sep 1, 2023
…#949)" (#1007) This reverts commit 4b21068. Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
added a commit
that referenced
this pull request
Sep 1, 2023
…#949)" (#1006) This reverts commit 4b21068. Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
added a commit
that referenced
this pull request
Sep 5, 2023
…ue (#1013) * Revert "[backport to 2.x] Enforce DOCUMENT Replication for AD Indices (#949)" This reverts commit 4b21068. Signed-off-by: Jackie Han <[email protected]> * upgrading commons-lang3 version to fix conflict issue (#1012) * force commons-lang3 version to fix conflict issue Signed-off-by: Jackie Han <[email protected]> * getting commons-lang3 version from upstream version properties file Signed-off-by: Jackie Han <[email protected]> * getting commons-lang3 version from core Signed-off-by: Jackie Han <[email protected]> * getting commons-lang3 version from core Signed-off-by: Jackie Han <[email protected]> * upgrading commons-lang3 version to align with core Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit db456c2) --------- Signed-off-by: Jackie Han <[email protected]>
jackiehanyang
added a commit
that referenced
this pull request
Sep 5, 2023
…sue (#1014) * Revert "[backport to 2.x] Enforce DOCUMENT Replication for AD Indices (#949)" This reverts commit 4b21068. Signed-off-by: Jackie Han <[email protected]> * upgrading commons-lang3 version to fix conflict issue (#1012) * force commons-lang3 version to fix conflict issue Signed-off-by: Jackie Han <[email protected]> * getting commons-lang3 version from upstream version properties file Signed-off-by: Jackie Han <[email protected]> * getting commons-lang3 version from core Signed-off-by: Jackie Han <[email protected]> * getting commons-lang3 version from core Signed-off-by: Jackie Han <[email protected]> * upgrading commons-lang3 version to align with core Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit db456c2) --------- Signed-off-by: Jackie Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we temporarily enforce DOCUMENT replication for AD indices. This change is necessary due to the current limitation of SegRep, which doesn't support Get/MultiGet by ID. This measure will be in place until SegRep adds support for these operations.
This adjustment aligns with the modification made in the referenced PR: opensearch-project/job-scheduler#417
Issues Resolved
#936
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.