Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with segment replication #936

Closed
Tracked by #8211
dreamer-89 opened this issue Jun 29, 2023 · 8 comments
Closed
Tracked by #8211

Compatibility with segment replication #936

dreamer-89 opened this issue Jun 29, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request v2.9.0

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Jun 29, 2023

Summary

With 2.9.0 release, there are lot of enhancements going in for segment replication[1][2] feature (went GA in 2.7.0), we need to ensure different plugins are compatible with current state of this feature. Previously, we ran tests on plugin repos to verify this compatibility but want plugin owners to be aware of these changes so that required updates (if any) can be made. With 2.10.0 release, remote store feature is going GA which internally uses SEGMENT replication strategy only i.e. it enforces all indices to use SEGMENT replication strategy. So, it is important to validate plugins are compatible with segment replication feature.

What changed

1. Refresh policy behavior

  1. RefreshPolicy.IMMEDIATE will only refresh primary shards but not replica shards immediately. Instead post refresh, primary will start a round of segment replication to update the replica shard copies leading to eventual consistency.
  2. RefreshPolicy.WAIT_UNTIL ensures the indexing operation is searchable in your cluster i.e. RAW (Read after write guarantee). With segment replication, this guarantee is not promised due to delay in replica shared updates from asynchronous background refreshes.

2. Refresh lag on replicas

With segment replication, there is inherent delay in documents to be searchable on replica shard copies. This is due to the fact that replica shard copies over data (segment) files from primary. Thus, compared to document replication, there will be on average increase in amount of time the replica shards are consistent with primaries.

3. System/hidden indices support

With opensearch-project/OpenSearch#8200, system and hidden indices are now supported with SEGMENT replication strategy. We need to ensure there are no bottlenecks which prevents system/hidden indices with segment replication.

Next steps

With segment replication strong reads are not guaranteed. Thus, if the plugin needs strong reads guarantees specially as alternative to change in behavior of refresh policy and lag on replicas (point 1 and 2 above), we need to update search requests to target primary shard only. With opensearch-project/OpenSearch#7375, core now supports primary shards only based search. Please follow documentation for examples and details

Open questions

In case of any questions or issues, please post it in core issue

Reference

[1] Design

[2] Documentation

@dreamer-89
Copy link
Member Author

Request owners to add v2.9.0 label on this issue.

@kaituo
Copy link
Collaborator

kaituo commented Jul 6, 2023

@dreamer-89 Our AD indices need RAW (e.g., we want users to be able to consume AD results as soon as possible and send out an alert if anomalies found). Can we just add index setting override to make sure our replication.type is Document?

@kaituo kaituo removed the untriaged label Jul 6, 2023
@kaituo kaituo self-assigned this Jul 6, 2023
@dreamer-89
Copy link
Member Author

dreamer-89 commented Jul 11, 2023

@dreamer-89 Our AD indices need RAW (e.g., we want users to be able to consume AD results as soon as possible and send out an alert if anomalies found). Can we just add index setting override to make sure our replication.type is Document?

Hi @kaituo,

Thanks for sharing your use case. You can override system/hidden indices to use DOCUMENT replication but then we are not truely testing the system indices with segment replication. This validation is important because going forward SEGMENT will be the only replication strategy supported for certain configurations (e.g. Remote store at cluster level). Thus, there is no way other than to validate indices actually created with SEGMENT replication.

Will using primary shard based searching as mentioned in the issue description solve your use case ?

@kaituo
Copy link
Collaborator

kaituo commented Jul 11, 2023

@dreamer-89 It can solve part of the problems. But the changes are wider and can easily miss edge cases (we have to scan all of our frontend code and public APIs). Also, we open our result indices for user to query. We will need to come up with a UX to warn users to search primary shards only. These changes cannot be done in 1 or 2 days and can be weeks of testing, UX design, and documentation process.

What is remote store at cluster level?

Also, will segment replication be the default starting from version 2.10? If so, can we discuss the decision further as it’s a breaking change that might affect both internal and external plugins. These plugins might not be familiar with the specifics of segment replications and may require strong reads. (cc @xinlamzn @anirudha @macohen @vamshin )

@dreamer-89
Copy link
Member Author

dreamer-89 commented Jul 11, 2023

@dreamer-89 It can solve part of the problems. But the changes are wider and can easily miss edge cases (we have to scan all of our frontend code and public APIs). Also, we open our result indices for user to query. We will need to come up with a UX to warn users to search primary shards only. These changes cannot be done in 1 or 2 days and can be weeks of testing, UX design, and documentation process.

What is remote store at cluster level?

Remote store[1] is a storage feature where OpenSearch cluster data is persisted on remote store for better durability. This feature is currently experimental and slated to go GA in 2.10.0.

By Remote store at cluster level, I meant remote store feature enabled at cluster level (via cluster level setting), which means all indices created, are by default remote store enabled. Due to its better durability guarantees, it will be the preferred solution for all type of indices including system/plugin indices. It will be de-facto storage model for clusters having hardware constrained nodes.

Also, will segment replication be the default starting from version 2.10? If so, can we discuss the decision further as it’s a breaking change that might affect both internal and external plugins. These plugins might not be familiar with the specifics of segment replications and may require strong reads. (cc @xinlamzn @anirudha @macohen @vamshin )

Remote store today only works with SEGMENT replication and not with DOCUMENT. Thus, when remote store is set at cluster level all indices are by default using segment replication. So, yes SEGMENT will be default when used with remote store enabled index (or cluster level setting).

[1] https://opensearch.org/docs/latest/tuning-your-cluster/availability-and-recovery/remote-store/index/

@kaituo
Copy link
Collaborator

kaituo commented Jul 11, 2023

@dreamer-89 I'll follow opensearch-project/job-scheduler#407 as a temporary solution until opensearch-project/OpenSearch#8536 is fixed.

@ohltyler
Copy link
Member

With #948 merged, can this issue be resolved, and a new one created for 2.10 when it is clear what more will be needed from plugins then?

@kaituo
Copy link
Collaborator

kaituo commented Jul 13, 2023

yes, closed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.9.0
Projects
None yet
Development

No branches or pull requests

4 participants