-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Remove Restriction of strictly using only docrep for system indices and hidden indices #8200
[Segment Replication] Remove Restriction of strictly using only docrep for system indices and hidden indices #8200
Conversation
…den indices. Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8200 +/- ##
============================================
+ Coverage 70.91% 70.93% +0.02%
- Complexity 56925 56965 +40
============================================
Files 4759 4759
Lines 269189 269181 -8
Branches 39399 39397 -2
============================================
+ Hits 190896 190954 +58
+ Misses 62205 62094 -111
- Partials 16088 16133 +45
|
We need to run integration tests for different plugins/modules using system indices to ensure no regression with Segrep. |
Signed-off-by: Rishikesh Pasham <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishikesh1159 <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this change @Rishikesh1159 we can test plugin compatibility with SR for 2.9.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8200-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bea26f97c66070581070764fe4790d2f0579c8e7
# Push it to GitHub
git push --set-upstream origin backport/backport-8200-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…p for system indices and hidden indices (opensearch-project#8200) * remove logic of strictly using only docrep for system indices and hidden indices. Signed-off-by: Rishikesh1159 <[email protected]> * Remove segrep-system indices related tests. Signed-off-by: Rishikesh1159 <[email protected]> * Fix failing tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]>
…p for system indices and hidden indices (opensearch-project#8200) * remove logic of strictly using only docrep for system indices and hidden indices. Signed-off-by: Rishikesh1159 <[email protected]> * Remove segrep-system indices related tests. Signed-off-by: Rishikesh1159 <[email protected]> * Fix failing tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]>
…p for system indices and hidden indices (opensearch-project#8200) * remove logic of strictly using only docrep for system indices and hidden indices. Signed-off-by: Rishikesh1159 <[email protected]> * Remove segrep-system indices related tests. Signed-off-by: Rishikesh1159 <[email protected]> * Fix failing tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]> Signed-off-by: sahil buddharaju <[email protected]>
…p for system indices and hidden indices (opensearch-project#8200) * remove logic of strictly using only docrep for system indices and hidden indices. Signed-off-by: Rishikesh1159 <[email protected]> * Remove segrep-system indices related tests. Signed-off-by: Rishikesh1159 <[email protected]> * Fix failing tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]>
…p for system indices and hidden indices (opensearch-project#8200) * remove logic of strictly using only docrep for system indices and hidden indices. Signed-off-by: Rishikesh1159 <[email protected]> * Remove segrep-system indices related tests. Signed-off-by: Rishikesh1159 <[email protected]> * Fix failing tests. Signed-off-by: Rishikesh1159 <[email protected]> --------- Signed-off-by: Rishikesh1159 <[email protected]> Signed-off-by: Rishikesh Pasham <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR removes the restriction of strictly using only docrep for system indices and hidden indices
Related Issues
Part of issue #8182
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.