Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Remove Restriction of strictly using only docrep for system indices and hidden indices #8200

Merged

Conversation

Rishikesh1159
Copy link
Member

Description

This PR removes the restriction of strictly using only docrep for system indices and hidden indices

Related Issues

Part of issue #8182

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.pit.DeletePitMultiNodeIT.testDeleteWhileSearch
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.CreateRemoteIndexTranslogDisabledIT.testRemoteStoreTranslogDisabledByUser

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #8200 (7bd8c64) into main (9e4e54d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #8200      +/-   ##
============================================
+ Coverage     70.91%   70.93%   +0.02%     
- Complexity    56925    56965      +40     
============================================
  Files          4759     4759              
  Lines        269189   269181       -8     
  Branches      39399    39397       -2     
============================================
+ Hits         190896   190954      +58     
+ Misses        62205    62094     -111     
- Partials      16088    16133      +45     
Impacted Files Coverage Δ
...h/cluster/metadata/MetadataCreateIndexService.java 79.82% <100.00%> (+0.06%) ⬆️

... and 476 files with indirect coverage changes

@ankitkala
Copy link
Member

We need to run integration tests for different plugins/modules using system indices to ensure no regression with Segrep.
To start with, can we run integration tests for security plugin(.opendistro_security) and task framework(.tasks) to ensure that there are no additional changes required for the system indices which are in critical path.
We can do it as a follow up.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Rishikesh1159 <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadRangeBlobWithRetries
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this change @Rishikesh1159 we can test plugin compatibility with SR for 2.9.

@mch2 mch2 merged commit bea26f9 into opensearch-project:main Jul 6, 2023
@Rishikesh1159 Rishikesh1159 added the backport 2.x Backport to 2.x branch label Jul 6, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8200-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bea26f97c66070581070764fe4790d2f0579c8e7
# Push it to GitHub
git push --set-upstream origin backport/backport-8200-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8200-to-2.x.

vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…p for system indices and hidden indices (opensearch-project#8200)

* remove logic of strictly using only docrep for system indices and hidden indices.

Signed-off-by: Rishikesh1159 <[email protected]>

* Remove segrep-system indices related tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix failing tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh Pasham <[email protected]>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…p for system indices and hidden indices (opensearch-project#8200)

* remove logic of strictly using only docrep for system indices and hidden indices.

Signed-off-by: Rishikesh1159 <[email protected]>

* Remove segrep-system indices related tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix failing tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh Pasham <[email protected]>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…p for system indices and hidden indices (opensearch-project#8200)

* remove logic of strictly using only docrep for system indices and hidden indices.

Signed-off-by: Rishikesh1159 <[email protected]>

* Remove segrep-system indices related tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix failing tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh Pasham <[email protected]>
Signed-off-by: sahil buddharaju <[email protected]>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…p for system indices and hidden indices (opensearch-project#8200)

* remove logic of strictly using only docrep for system indices and hidden indices.

Signed-off-by: Rishikesh1159 <[email protected]>

* Remove segrep-system indices related tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix failing tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh Pasham <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…p for system indices and hidden indices (opensearch-project#8200)

* remove logic of strictly using only docrep for system indices and hidden indices.

Signed-off-by: Rishikesh1159 <[email protected]>

* Remove segrep-system indices related tests.

Signed-off-by: Rishikesh1159 <[email protected]>

* Fix failing tests.

Signed-off-by: Rishikesh1159 <[email protected]>

---------

Signed-off-by: Rishikesh1159 <[email protected]>
Signed-off-by: Rishikesh Pasham <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants