fixing dls/fls logic around numeric aggregations #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaituo Li <[email protected]>
|
Weird that it says it can't get the zip for job scheduler but even the link in the error message works fine to download job-scheduler-1.3.8.0 |
Indeed. |
amitgalitz
approved these changes
Jan 26, 2023
ylwu-amzn
reviewed
Jan 27, 2023
| user = jobParameter.getUser().getName(); | ||
| roles = jobParameter.getUser().getRoles(); | ||
| } | ||
| User userInfo = SecurityUtil.getUserFromJob(jobParameter, settings); |
There was a problem hiding this comment.
Is this ready user information stored in AD job? I think we have no way to get user information from security plugin. Just asking to learn more
There was a problem hiding this comment.
Yes, it is from AD job.
ylwu-amzn
reviewed
Jan 27, 2023
| import org.opensearch.ad.util.DiscoveryNodeFilterer; | ||
| import org.opensearch.ad.util.IndexUtils; | ||
| import org.opensearch.ad.util.Throttler; | ||
| import org.opensearch.ad.util.*; |
There was a problem hiding this comment.
minor: should we avoid using import *?
There was a problem hiding this comment.
Yes, will fix in other PRs since 1.3.8 is due today.
ylwu-amzn
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kaituo Li [email protected]
Issues Resolved
#788
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.