Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to 1.3] removed bwc zips and fetching opendistro from cloudfront (#505) #565

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Jun 6, 2022

Signed-off-by: Amit Galitzky [email protected]

Description

Original PR: #505

Most of the CVEs for the 1.3 branch are due to the bwc test snapshot file. This PR removes test snapshot files from the repo and adds links to download resource files for bwc test. That would resolve the CVE as long as it’s not stored in the repo.

Testing done:

  1. verified bwc tests are passing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaituo can you add this PR into the 1.3 release notes I just merged? #564

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2022

Codecov Report

Merging #565 (b4bc699) into 1.3 (b62de79) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.3     #565      +/-   ##
============================================
+ Coverage     77.74%   77.83%   +0.08%     
- Complexity     4116     4122       +6     
============================================
  Files           296      296              
  Lines         17687    17687              
  Branches       1884     1884              
============================================
+ Hits          13751    13766      +15     
+ Misses         3033     3018      -15     
  Partials        903      903              
Flag Coverage Δ
plugin 77.83% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 84.04% <0.00%> (+0.30%) ⬆️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 76.98% <0.00%> (+0.67%) ⬆️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 90.12% <0.00%> (+1.23%) ⬆️
...port/SearchAnomalyDetectorInfoTransportAction.java 68.88% <0.00%> (+6.66%) ⬆️

Copy link
Member

@amitgalitz amitgalitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this change to 1.3

@kaituo
Copy link
Collaborator Author

kaituo commented Jun 8, 2022

@kaituo can you add this PR into the 1.3 release notes I just merged? #564

sure.

@kaituo kaituo merged commit d1bfdd7 into opensearch-project:1.3 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants