Remove BWC zips for dynamic dependency #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
opensearch-trigger-bot
bot
added
backport 1.x
infra
ohltyler
approved these changes
Apr 18, 2022
ylwu-amzn
approved these changes
Apr 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #505 +/- ##
============================================
- Coverage 78.95% 78.91% -0.04%
+ Complexity 4194 4191 -3
============================================
Files 296 296
Lines 17663 17663
Branches 1878 1878
============================================
- Hits 13946 13939 -7
- Misses 2816 2822 +6
- Partials 901 902 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
pushed a commit
to kaituo/anomaly-detection-1
that referenced
this pull request
Jun 6, 2022
…project#505) Signed-off-by: Amit Galitzky <[email protected]>
kaituo
added a commit
that referenced
this pull request
Jun 8, 2022
Signed-off-by: Amit Galitzky <[email protected]> Co-authored-by: Amit Galitzky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky [email protected]
Description
Removed BWC zips still present in AD by fetching from opendistro cloudfront. Other zips such as 1.1 and 1.2 weren't not correctly used at all during our build process anyway. Currently the BWC testing we do is from current version to 7.10.2/1.13. We will handle more bwc testing in a different PR as outlined by this issue (#336)
I also uncommented bwc test in CI.
Issues Resolved
resolves #17
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.