-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more unit tests for AD transport actions #498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-trigger-bot
bot
added
backport 1.x
infra
Changes to infrastructure, testing, CI/CD, pipelines, etc.
labels
Apr 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #498 +/- ##
============================================
+ Coverage 78.16% 78.50% +0.33%
- Complexity 4159 4177 +18
============================================
Files 296 296
Lines 17663 17663
Branches 1878 1878
============================================
+ Hits 13807 13866 +59
+ Misses 2959 2904 -55
+ Partials 897 893 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Zhangxunmt
force-pushed
the
main
branch
2 times, most recently
from
April 14, 2022 16:35
2f3451d
to
1bb0bcd
Compare
ylwu-amzn
previously approved these changes
Apr 14, 2022
Zhangxunmt
force-pushed
the
main
branch
3 times, most recently
from
April 15, 2022 00:53
2a7c0ff
to
7ba35fc
Compare
Signed-off-by: Xun Zhang <[email protected]>
ylwu-amzn
approved these changes
Apr 15, 2022
ohltyler
approved these changes
Apr 15, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-498-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9a25a4d3c5f3977137d47c202ce46849348af1b8
# Push it to GitHub
git push --set-upstream origin backport/backport-498-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
aksingh-es
removed
the
infra
Changes to infrastructure, testing, CI/CD, pipelines, etc.
label
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xun Zhang [email protected]
Description
Increase tests coverage for GetAnomalyDetectorTransportAction and remove it and subclasses from Jacoco exclusive list.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.