Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more unit tests for AD transport actions #498

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

Zhangxunmt
Copy link
Contributor

Signed-off-by: Xun Zhang [email protected]

Description

Increase tests coverage for GetAnomalyDetectorTransportAction and remove it and subclasses from Jacoco exclusive list.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt requested a review from a team April 12, 2022 04:28
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 1.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Apr 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #498 (b3e97ec) into main (9d44f1b) will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #498      +/-   ##
============================================
+ Coverage     78.16%   78.50%   +0.33%     
- Complexity     4159     4177      +18     
============================================
  Files           296      296              
  Lines         17663    17663              
  Branches       1878     1878              
============================================
+ Hits          13807    13866      +59     
+ Misses         2959     2904      -55     
+ Partials        897      893       -4     
Flag Coverage Δ
plugin 78.50% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/ad/task/ADTaskManager.java 77.13% <0.00%> (+0.22%) ⬆️
.../main/java/org/opensearch/ad/ml/CheckpointDao.java 70.19% <0.00%> (+0.64%) ⬆️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 92.59% <0.00%> (+2.46%) ⬆️
...ansport/handler/AnomalyResultBulkIndexHandler.java 70.96% <0.00%> (+3.22%) ⬆️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 85.71% <0.00%> (+3.95%) ⬆️
...d/transport/GetAnomalyDetectorTransportAction.java 75.44% <0.00%> (+14.37%) ⬆️

@Zhangxunmt Zhangxunmt force-pushed the main branch 2 times, most recently from 2f3451d to 1bb0bcd Compare April 14, 2022 16:35
ylwu-amzn
ylwu-amzn previously approved these changes Apr 14, 2022
@Zhangxunmt Zhangxunmt merged commit 9a25a4d into opensearch-project:main Apr 15, 2022
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-498-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9a25a4d3c5f3977137d47c202ce46849348af1b8
# Push it to GitHub
git push --set-upstream origin backport/backport-498-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-498-to-1.x.

@aksingh-es aksingh-es removed the infra Changes to infrastructure, testing, CI/CD, pipelines, etc. label Apr 21, 2022
@ylwu-amzn ylwu-amzn mentioned this pull request Apr 21, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants