Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add more tests coverage for AD transport layer #492

Closed
Zhangxunmt opened this issue Apr 5, 2022 · 2 comments
Closed

[BUG] Add more tests coverage for AD transport layer #492

Zhangxunmt opened this issue Apr 5, 2022 · 2 comments
Assignees
Labels
bug Something isn't working v2.0.0

Comments

@Zhangxunmt
Copy link
Contributor

Zhangxunmt commented Apr 5, 2022

The jacocoExclusions list includes lots of classes in AD transport layer. https://github.com/opensearch-project/anomaly-detection/blob/main/build.gradle#L513. They lack tests coverage which may cause bugs.
We should add tests into the following classes in the transport layer.

    'org.opensearch.ad.transport.StopDetectorRequest',
    'org.opensearch.ad.transport.StopDetectorResponse',
    'org.opensearch.ad.transport.CronRequest',

    // related to transport actions added for security
    'org.opensearch.ad.transport.DeleteAnomalyDetectorTransportAction*',
    'org.opensearch.ad.transport.GetAnomalyDetectorTransportAction*',
    'org.opensearch.ad.transport.SearchAnomalyResultTransportAction*',
    'org.opensearch.ad.transport.SearchAnomalyDetectorInfoTransportAction*',
    'org.opensearch.ad.transport.AnomalyDetectorJobRequest',
@Zhangxunmt
Copy link
Contributor Author

The listed classes are removed from the jacoco exclusive list. PR: #498

@Zhangxunmt
Copy link
Contributor Author

PR is merged. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.0.0
Projects
None yet
Development

No branches or pull requests

1 participant