Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] jacocoExclusions is very long #424

Open
dblock opened this issue Mar 10, 2022 · 2 comments
Open

[BUG] jacocoExclusions is very long #424

dblock opened this issue Mar 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working Priority-Medium v3.0.0

Comments

@dblock
Copy link
Member

dblock commented Mar 10, 2022

Describe the bug

The jacocoExclusions list is quite long, https://github.com/opensearch-project/anomaly-detection/blob/main/build.gradle#L478. Maybe we're just ignoring coverage thresholds, or they are too high? In either case those thresholds are likely not useful.

Either fix the TODOs and reduce the list, or remove/reduce the coverage thresholds.

@Zhangxunmt
Copy link
Contributor

The restful action layer is covered by integration tests, so they are excluded in the UT. The transport action layer are still missing some coverage. I am adding more unit tests for the following classes in transport layer for AD.

    'org.opensearch.ad.transport.StopDetectorRequest',
    'org.opensearch.ad.transport.StopDetectorResponse',
    'org.opensearch.ad.transport.CronRequest',
    'org.opensearch.ad.AnomalyDetectorRunner',

    'org.opensearch.ad.transport.DeleteAnomalyDetectorTransportAction*',
    'org.opensearch.ad.transport.GetAnomalyDetectorTransportAction*',
    'org.opensearch.ad.transport.SearchAnomalyResultTransportAction*',
    'org.opensearch.ad.transport.SearchAnomalyDetectorInfoTransportAction*',
    'org.opensearch.ad.transport.AnomalyDetectorJobRequest',

    'org.opensearch.ad.transport.DeleteAnomalyResultsTransportAction',
    'org.opensearch.ad.transport.handler.AnomalyResultBulkIndexHandler'

Also, these 2 task runners also needs more tests. We can address them in the next.
// #241
'org.opensearch.ad.task.ADBatchTaskRunner',
'org.opensearch.ad.task.ADTaskManager',

@Zhangxunmt
Copy link
Contributor

Zhangxunmt commented Apr 5, 2022

break down this issue into several sub-issues in 492 and 493. The classes that will be removed out of the jacocoExclusions are identified in the above two issues. The rest layer classes are tested in integration tests so we will keep them in the jacocoExclusions list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority-Medium v3.0.0
Projects
None yet
Development

No branches or pull requests

4 participants